Attachment 360786 Details for Bug 194111 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

memory-1.patch (text/plain), 1.89 KB, created by Joseph Pecoraro on 2019-01-31 14:38:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-31 14:38:37 PST

Size: 1.89 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 083bb3d0dfd..e28ea777792 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-31  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Memory timeline starts from zero when both CPU and Memory timeline are enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=194111
>+        <rdar://problem/47714555>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/ResourceUsageThread.cpp:
>+        (WebCore::ResourceUsageThread::waitUntilObservers):
>+        (WebCore::ResourceUsageThread::threadBody):
>+        Wait a short period of time before the first listener registers
>+        and we start sampling. This will allow multiple listeners to
>+        register, each that wants different data.
>+
> 2019-01-31  Darin Adler  <darin@apple.com>
> 
>         Simplify and streamline code that creates an appropriate document based on MIME type
>diff --git a/Source/WebCore/page/ResourceUsageThread.cpp b/Source/WebCore/page/ResourceUsageThread.cpp
>index d9dd3e769ed..5036260c9c4 100644
>--- a/Source/WebCore/page/ResourceUsageThread.cpp
>+++ b/Source/WebCore/page/ResourceUsageThread.cpp
>@@ -78,8 +78,12 @@ void ResourceUsageThread::removeObserver(void* key)
> void ResourceUsageThread::waitUntilObservers()
> {
>     LockHolder locker(m_lock);
>-    while (m_observers.isEmpty())
>+    while (m_observers.isEmpty()) {
>         m_condition.wait(m_lock);
>+
>+        // Wait a bit after waking up for the first time.
>+        WTF::sleep(10_ms);
>+    }
> }
> 
> void ResourceUsageThread::notifyObservers(ResourceUsageData&& data)
>@@ -119,6 +123,9 @@ void ResourceUsageThread::createThreadIfNeeded()
> 
> NO_RETURN void ResourceUsageThread::threadBody()
> {
>+    // Wait a bit after waking up for the first time.
>+    WTF::sleep(10_ms);
>+    
>     while (true) {
>         // Only do work if we have observers.
>         waitUntilObservers();

Flags:

hi: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194111: 360786