Attachment 360778 Details for Bug 194109 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

better-2.patch (text/plain), 2.91 KB, created by Joseph Pecoraro on 2019-01-31 14:13:57 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-31 14:13:57 PST

Size: 2.91 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index e1d4d35137f..c80fbcd0021 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-31  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Timeline time range selection should show duration alongside start and end
>+        https://bugs.webkit.org/show_bug.cgi?id=194109
>+        <rdar://problem/47714279>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+        * UserInterface/Views/TimelineRecordingContentView.js:
>+        (WI.TimelineRecordingContentView.prototype._updateTimeRangePathComponents):
>+        Include the duration when not obvious.
>+
> 2019-01-31  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Timeline time range selection sometimes shows 0.000, should be just 0
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index e7084f29858..d8c79558caa 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -54,6 +54,7 @@ localizedStrings["%s Fired"] = "%s Fired";
> localizedStrings["%s Prototype"] = "%s Prototype";
> localizedStrings["%s Result"] = "%s Result";
> localizedStrings["%s \u2013 %s"] = "%s \u2013 %s";
>+localizedStrings["%s \u2013 %s (%s)"] = "%s \u2013 %s (%s)";
> localizedStrings["%s \u2014 %s"] = "%s \u2014 %s";
> localizedStrings["%s cannot be modified"] = "%s cannot be modified";
> localizedStrings["%s delay"] = "%s delay";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>index f54c76775bb..029d7e48543 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>@@ -731,7 +731,13 @@ WI.TimelineRecordingContentView = class TimelineRecordingContentView extends WI.
>         if (this._timelineOverview.viewMode === WI.TimelineOverview.ViewMode.Timelines) {
>             let selectionStart = Number.secondsToString(startValue, true);
>             let selectionEnd = Number.secondsToString(endValue, true);
>-            displayName = WI.UIString("%s \u2013 %s").format(selectionStart, selectionEnd);
>+            const epsilon = 0.0001;
>+            if (startValue < epsilon)
>+                displayName = WI.UIString("%s \u2013 %s").format(selectionStart, selectionEnd);
>+            else {
>+                let duration = Number.secondsToString(endValue - startValue, true);
>+                displayName = WI.UIString("%s \u2013 %s (%s)").format(selectionStart, selectionEnd, duration);
>+            }
>         } else {
>             startValue += 1; // Convert index to frame number.
>             if (startValue === endValue)

Flags:

hi: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194109: 360776 | 360777 | 360778