Attachment 360772 Details for Bug 194112 – Patch

[patch] Patch

bug-194112-20190131140328.patch (text/plain), 2.18 KB, created by Tadeu Zagallo on 2019-01-31 14:03:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-01-31 14:03:49 PST

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 240811
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index e5bc3208383c3959f8bc013012c9f0fe2c43ae27..b2cc897075b77858b2126df8fc8c0af26469fbb8 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-31  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        testapi fails RELEASE_ASSERT(codeBlock) in fetchFromDisk() of CodeCache.h
>+        https://bugs.webkit.org/show_bug.cgi?id=194112
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        `testBytecodeCache` does not populate the bytecode cache for the global
>+        CodeBlock, so it should only enable `forceDiskCache` after its execution.
>+
>+        * API/tests/testapi.mm:
>+        (testBytecodeCache):
>+
> 2019-01-31  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Unreviewed, follow-up after r240796
>diff --git a/Source/JavaScriptCore/API/tests/testapi.mm b/Source/JavaScriptCore/API/tests/testapi.mm
>index 834913161bce57daf23cd882747dc49ad3261c2a..a48a0b344de87f6ad960f069b965716d92c75b56 100644
>--- a/Source/JavaScriptCore/API/tests/testapi.mm
>+++ b/Source/JavaScriptCore/API/tests/testapi.mm
>@@ -2002,6 +2002,7 @@ static void testBytecodeCache()
>         [bazSource writeToURL:bazPath atomically:NO encoding:NSASCIIStringEncoding error:nil];
> 
>         auto block = ^(JSContext *context, JSValue *identifier, JSValue *resolve, JSValue *reject) {
>+            JSC::Options::forceDiskCache() = true;
>             if ([identifier isEqualToObject:@"file:///directory/bar.js"])
>                 [resolve callWithArguments:@[[JSScript scriptFromASCIIFile:fooPath inVirtualMachine:context.virtualMachine withCodeSigning:nil andBytecodeCache:fooCachePath]]];
>             else if ([identifier isEqualToObject:@"file:///foo.js"])
>@@ -2013,7 +2014,6 @@ static void testBytecodeCache()
>         };
> 
>         @autoreleasepool {
>-            JSC::Options::forceDiskCache() = true;
>             auto *context = [JSContextFetchDelegate contextWithBlockForFetch:block];
>             context.moduleLoaderDelegate = context;
>             JSValue *promise = [context evaluateScript:@"import('../otherDirectory/baz.js');" withSourceURL:[NSURL fileURLWithPath:@"/directory" isDirectory:YES]];

Actions: View | Formatted Diff | Diff

Attachments on bug 194112: 360772