Attachment 360759 Details for Bug 191041 – Patch

[patch] Patch

bug-191041-20190131125542.patch (text/plain), 3.08 KB, created by Chris Dumez on 2019-01-31 12:55:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-01-31 12:55:43 PST

Size: 3.08 KB

patch

obsolete

>Subversion Revision: 240793
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b0be8865e22218951b2b718d8419c6b0e2351fb0..22def862b9ab649dce78ad38a63cbc5a72e3d2f7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-31  Chris Dumez  <cdumez@apple.com>
>+
>+        [ MacOS ] Layout Test performance-api/performance-observer-callback-after-gc.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=191041
>+        <rdar://problem/45649982>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make the test print the same output no matter if the performance observer is notified once or
>+        twice. What matters is that it is notified about 3 marks.
>+
>+        * performance-api/performance-observer-callback-after-gc-expected.txt:
>+        * performance-api/performance-observer-callback-after-gc.html:
>+
> 2019-01-31  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
>diff --git a/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt b/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt
>index 7db02f9f7ae436f7c6a27e82887b63c22c925db3..5501478310221bb028c5778a0fca65f3309cf0be 100644
>--- a/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt
>+++ b/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt
>@@ -3,9 +3,7 @@ Ensure PerformanceObserver callback fires even if the JS does not keep the Perfo
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-PerformanceObserver callback fired: 1 entries
> PASS mark1
>-PerformanceObserver callback fired: 2 entries
> PASS mark2
> PASS mark3
> PASS successfullyParsed is true
>diff --git a/LayoutTests/performance-api/performance-observer-callback-after-gc.html b/LayoutTests/performance-api/performance-observer-callback-after-gc.html
>index 00af012ee147092eeb450501f9c853526a3e550f..8495302100f61304660848367085b1dcc3f51624 100644
>--- a/LayoutTests/performance-api/performance-observer-callback-after-gc.html
>+++ b/LayoutTests/performance-api/performance-observer-callback-after-gc.html
>@@ -8,14 +8,17 @@
> description("Ensure PerformanceObserver callback fires even if the JS does not keep the PerformanceObserver object alive.");
> window.jsTestIsAsync = true;
> 
>-let shouldEnd = false;
>+let receivedEntries = [];
> 
> let observer = new PerformanceObserver((list) => {
>-    debug("PerformanceObserver callback fired: " + list.getEntries().length + " entries");
>     for (let mark of list.getEntries())
>-        testPassed(mark.name);
>-    if (shouldEnd)
>-        finishJSTest();
>+        receivedEntries.push(mark.name);
>+
>+    if (receivedEntries.length == 3) {
>+        for (let name of receivedEntries)
>+            testPassed(name);
>+       finishJSTest();
>+    }
> });
> observer.observe({entryTypes: ["mark"]});
> observer = null;
>@@ -29,7 +32,6 @@ setTimeout(() => {
>     gc();
>     performance.mark("mark2");
>     performance.mark("mark3");
>-    shouldEnd = true;
> }, 50);
> </script>
> <script src="../resources/js-test-post.js"></script>

Actions: View | Formatted Diff | Diff

Attachments on bug 191041: 360759