Attachment 360746 Details for Bug 191303 – Patch

[patch] Patch

bug-191303-20190131201257.patch (text/plain), 3.88 KB, created by darshan on 2019-01-31 11:12:58 PST

(hide)

Description:

Filename:

MIME Type:

Creator: darshan

Created: 2019-01-31 11:12:58 PST

Size: 3.88 KB

patch

obsolete

>Subversion Revision: 240715
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9b48791eb108c0b3fb78af7d052d7b6618f23b98..7e569a1464865c6da5adcd37aba385197c8dc3d0 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-31  Darshan Kadu  <dkadu@igalia.com>
>+
>+        DumpRenderTree should report unknown options
>+        https://bugs.webkit.org/show_bug.cgi?id=191303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added RELEASE_ASSERT for DumpRenderTree/TestOptions.cpp DumpRenderTree
>+        to report unknown options.
>+        Added dummy if conditions to pass tests on bot.
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+
> 2019-01-30  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r240708.
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index c926612b1b1604a83ce2603bcda88ce3983d358e..1ec3f818963896718a22f77f3bbe565781162aee 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -75,7 +75,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>         auto value = pairString.substr(equalsLocation + 1, pairEnd - (equalsLocation + 1));
>         if (key == "enableAttachmentElement")
>             enableAttachmentElement = parseBooleanTestHeaderValue(value);
>-        if (key == "useAcceleratedDrawing")
>+        else if (key == "useAcceleratedDrawing")
>             useAcceleratedDrawing = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIntersectionObserver")
>             enableIntersectionObserver = parseBooleanTestHeaderValue(value);
>@@ -111,6 +111,46 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             enableCSSLogical = parseBooleanTestHeaderValue(value);
>         else if (key == "internal:AdClickAttributionEnabled")
>             adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
>+        else if (key == "applicationManifest")
>+        { }
>+        else if (key =="experimental:CSSCustomPropertiesAndValuesEnabled")
>+        { }
>+        else if (key =="useFlexibleViewport")
>+        { }
>+        else if (key =="useThreadedScrolling")
>+        { }
>+        else if (key =="experimental:DarkModeCSSEnabled")
>+        { }
>+        else if (key =="experimental:CSSTypedOMEnabled")
>+        { }
>+        else if (key =="punchOutWhiteBackgrounds")
>+        { }
>+        else if (key =="enableEditableImages")
>+        { }
>+        else if (key =="useCharacterSelectionGranularity")
>+        { }
>+        else if (key =="spellCheckingDots")
>+        { }
>+        else if (key =="experimental:CSSPaintingAPIEnabled")
>+        { }
>+        else if (key =="experimental:PointerEventsEnabled")
>+        { }
>+        else if (key =="useMockScrollbars")
>+        { }
>+        else if (key =="ignoresViewportScaleLimits")
>+        { }
>+        else if (key =="shouldIgnoreMetaViewport")
>+        { }
>+        else if (key =="enableProcessSwapOnNavigation")
>+        { }
>+        else if (key =="runSingly")
>+        { }
>+        else if (key =="internal:WebAPIStatisticsEnabled")
>+        { }
>+        else if (key =="internal:SourceBufferChangeTypeEnabled")
>+        { }
>+        else
>+            RELEASE_ASSERT(false);
>         pairStart = pairEnd + 1;
>     }
> }
>diff --git a/LayoutTests/applicationmanifest/display-mode-subframe.html b/LayoutTests/applicationmanifest/display-mode-subframe.html
>index 75e1ba25e52fafc7d46c87115b99b2a7fc774d83..f27a5f71752f2d8985178cbe64ff459db892538f 100644
>--- a/LayoutTests/applicationmanifest/display-mode-subframe.html
>+++ b/LayoutTests/applicationmanifest/display-mode-subframe.html
>@@ -1,4 +1,4 @@
>-
>+
> <script>
> if (window.testRunner)
> 	testRunner.dumpChildFramesAsText();

Actions: View | Formatted Diff | Diff

Attachments on bug 191303: 358263 | 358456 | 360474 | 360733 | 360737 | 360738 | 360743 | 360746 | 360760 | 360762 | 360768 | 360769 | 360779 | 360865 | 360913 | 361201 | 361302 | 361683 | 361687 | 362238