Attachment 360741 Details for Bug 194096 – Patch

[patch] Patch

bug-194096-20190131103734.patch (text/plain), 4.77 KB, created by Benjamin Poulain on 2019-01-31 10:37:35 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Poulain

Created: 2019-01-31 10:37:35 PST

Size: 4.77 KB

patch

obsolete

>Subversion Revision: 240791
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dd09e1bcd77c13904f0edef65253f119395e0a05..27274e902b34b9df14a0a65140498ea6b50e036d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-01-31  Benjamin Poulain  <benjamin@webkit.org>
>+
>+        Remove WKPageIsWebProcessResponsive
>+        https://bugs.webkit.org/show_bug.cgi?id=194096
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It is not used by any client.
>+
>+        It is also bad API. It is better to let WebKit track
>+        responsiveness and tell the client with processDidBecomeResponsive.
>+
>+        * UIProcess/API/C/WKPage.cpp:
>+        (WKPageIsWebProcessResponsive): Deleted.
>+        * UIProcess/API/C/WKPagePrivate.h:
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::isWebProcessResponsive): Deleted.
>+        * UIProcess/WebPageProxy.h:
>+
> 2019-01-30  Simon Fraser  <simon.fraser@apple.com>
> 
>         [Mac] Implement basic hit testing in the scrolling tree
>diff --git a/Source/WebKit/UIProcess/API/C/WKPage.cpp b/Source/WebKit/UIProcess/API/C/WKPage.cpp
>index 35ff0786f88c2e3251e2411e8616d9f6d3a1c11e..84104ac80bb738a0ff8c4713a3fa36b7b24fa2d4 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPage.cpp
>+++ b/Source/WebKit/UIProcess/API/C/WKPage.cpp
>@@ -2327,13 +2327,6 @@ void WKPageGetSamplingProfilerOutput(WKPageRef pageRef, void* context, WKPageGet
>     toImpl(pageRef)->getSamplingProfilerOutput(toGenericCallbackFunction(context, callback));
> }
> 
>-void WKPageIsWebProcessResponsive(WKPageRef pageRef, void* context, WKPageIsWebProcessResponsiveFunction callback)
>-{
>-    toImpl(pageRef)->isWebProcessResponsive([context, callback](bool isWebProcessResponsive) {
>-        callback(isWebProcessResponsive, context);
>-    });
>-}
>-
> void WKPageGetSelectionAsWebArchiveData(WKPageRef pageRef, void* context, WKPageGetSelectionAsWebArchiveDataFunction callback)
> {
>     toImpl(pageRef)->getSelectionAsWebArchiveData(toGenericCallbackFunction(context, callback));
>diff --git a/Source/WebKit/UIProcess/API/C/WKPagePrivate.h b/Source/WebKit/UIProcess/API/C/WKPagePrivate.h
>index e09e2da4c130522add58c4ee2f678a3cd998851e..2d898b83d6c935861e45dc3cbef6a14864fff85c 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPagePrivate.h
>+++ b/Source/WebKit/UIProcess/API/C/WKPagePrivate.h
>@@ -103,9 +103,6 @@ WK_EXPORT void WKPageGetBytecodeProfile(WKPageRef page, void* context, WKPageGet
> typedef void (*WKPageGetSamplingProfilerOutputFunction)(WKStringRef, WKErrorRef, void*);
> WK_EXPORT void WKPageGetSamplingProfilerOutput(WKPageRef page, void* context, WKPageGetSamplingProfilerOutputFunction function);
> 
>-typedef void (*WKPageIsWebProcessResponsiveFunction)(bool isWebProcessResponsive, void* context);
>-WK_EXPORT void WKPageIsWebProcessResponsive(WKPageRef page, void* context, WKPageIsWebProcessResponsiveFunction function);
>-    
> WK_EXPORT WKArrayRef WKPageCopyRelatedPages(WKPageRef page);
> 
> WK_EXPORT WKFrameRef WKPageLookUpFrameFromHandle(WKPageRef page, WKFrameHandleRef handle);
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index f8a299508792811026c6bf24967a9563fcca8ee2..c7e09d82166912f2561c82a38a631ed378c00127 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -3538,19 +3538,6 @@ void WebPageProxy::getSamplingProfilerOutput(WTF::Function<void (const String&,
>     m_process->send(Messages::WebPage::GetSamplingProfilerOutput(callbackID), m_pageID);
> }
> 
>-void WebPageProxy::isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&& callbackFunction)
>-{
>-    if (!isValid()) {
>-        RunLoop::main().dispatch([callbackFunction = WTFMove(callbackFunction)] {
>-            bool isWebProcessResponsive = true;
>-            callbackFunction(isWebProcessResponsive);
>-        });
>-        return;
>-    }
>-
>-    m_process->isResponsive(WTFMove(callbackFunction));
>-}
>-
> #if ENABLE(MHTML)
> void WebPageProxy::getContentsAsMHTMLData(Function<void (API::Data*, CallbackBase::Error)>&& callbackFunction)
> {
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.h b/Source/WebKit/UIProcess/WebPageProxy.h
>index 3abd335f97010574a64c47cd94bca03b563a6a46..892ffcd68b68951f1167c8de8e007a7dba223ff1 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.h
>+++ b/Source/WebKit/UIProcess/WebPageProxy.h
>@@ -945,7 +945,6 @@ public:
>     void getContentsAsString(WTF::Function<void (const String&, CallbackBase::Error)>&&);
>     void getBytecodeProfile(WTF::Function<void (const String&, CallbackBase::Error)>&&);
>     void getSamplingProfilerOutput(WTF::Function<void (const String&, CallbackBase::Error)>&&);
>-    void isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&&);
> 
> #if ENABLE(MHTML)
>     void getContentsAsMHTMLData(Function<void (API::Data*, CallbackBase::Error)>&&);

Actions: View | Formatted Diff | Diff

Attachments on bug 194096: 360741