Attachment 360740 Details for Bug 194097 – Patch

[patch] Patch

bug-194097-20190131103554.patch (text/plain), 2.71 KB, created by Timothy Hatcher on 2019-01-31 10:35:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2019-01-31 10:35:54 PST

Size: 2.71 KB

patch

obsolete

>Subversion Revision: 240795
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dd09e1bcd77c13904f0edef65253f119395e0a05..bb92455d6515e30597f52d0a33ebf390182bb925 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-31  Timothy Hatcher  <timothy@apple.com>
>+
>+        Fix LSAppLink deprecation warnings.
>+        https://bugs.webkit.org/show_bug.cgi?id=194097
>+
>+        Unreviewed build fix.
>+
>+        * UIProcess/ios/WKActionSheetAssistant.mm:
>+        (-[WKActionSheetAssistant _appendOpenActionsForURL:actions:elementInfo:]):
>+
> 2019-01-30  Simon Fraser  <simon.fraser@apple.com>
> 
>         [Mac] Implement basic hit testing in the scrolling tree
>diff --git a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>index 148349ab3b0cfe3eef1b0d859eff2c978f15f7e7..5f2dd2e5cbff274ba7c9a9ed2716211007ef0684 100644
>--- a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>+++ b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>@@ -438,7 +438,10 @@ - (void)_appendOpenActionsForURL:(NSURL *)url actions:(NSMutableArray *)defaultA
>         if (appLink) {
>             NSString *title = WEB_UI_STRING("Open in Safari", "Title for Open in Safari Link action button");
>             _WKElementAction *openInDefaultBrowserAction = [_WKElementAction _elementActionWithType:_WKElementActionTypeOpenInDefaultBrowser title:title actionHandler:^(_WKActivatedElementInfo *) {
>+#pragma clang diagnostic push
>+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>                 [appLink openInWebBrowser:YES setAppropriateOpenStrategyAndWebBrowserState:nil completionHandler:^(BOOL success, NSError *error) { }];
>+#pragma clang diagnostic pop
>             }];
>             [defaultActions addObject:openInDefaultBrowserAction];
> 
>@@ -446,7 +449,10 @@ - (void)_appendOpenActionsForURL:(NSURL *)url actions:(NSMutableArray *)defaultA
>             if (externalApplicationName) {
>                 NSString *title = [NSString stringWithFormat:WEB_UI_STRING("Open in â%@â", "Title for Open in External Application Link action button"), externalApplicationName];
>                 _WKElementAction *openInExternalApplicationAction = [_WKElementAction _elementActionWithType:_WKElementActionTypeOpenInExternalApplication title:title actionHandler:^(_WKActivatedElementInfo *) {
>+#pragma clang diagnostic push
>+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>                     [appLink openInWebBrowser:NO setAppropriateOpenStrategyAndWebBrowserState:nil completionHandler:^(BOOL success, NSError *error) { }];
>+#pragma clang diagnostic pop
>                 }];
>                 [defaultActions addObject:openInExternalApplicationAction];
>             }

Actions: View | Formatted Diff | Diff

Attachments on bug 194097: 360740