Attachment 360736 Details for Bug 194094 – Patch

[patch] Patch

bug-194094-20190131095616.patch (text/plain), 1.86 KB, created by Chris Dumez on 2019-01-31 09:56:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-01-31 09:56:17 PST

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 240793
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dd09e1bcd77c13904f0edef65253f119395e0a05..99e1feed4b15baa79d84a29286fc9dbe2fb00339 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-31  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression(PSON) Crash under WebProcessProxy::canTerminateChildProcess()
>+        https://bugs.webkit.org/show_bug.cgi?id=194094
>+        <rdar://problem/47580753>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If a SuspendedPageProxy gets destroyed while a WebPageProxy is waiting for its to finish to suspend,
>+        call the "failure to suspend" completion handler asynchronously instead of synchronouly to make sure
>+        the completion handler cannot try and use the suspended page proxy while it is being destroyed.
>+
>+        * UIProcess/SuspendedPageProxy.cpp:
>+        (WebKit::SuspendedPageProxy::~SuspendedPageProxy):
>+
> 2019-01-30  Simon Fraser  <simon.fraser@apple.com>
> 
>         [Mac] Implement basic hit testing in the scrolling tree
>diff --git a/Source/WebKit/UIProcess/SuspendedPageProxy.cpp b/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
>index 049507e196417b0fbaf275d6b03fc1e7bd72463f..0c981f2976f86b17fecf9b465fb657c0cb208c0c 100644
>--- a/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
>@@ -92,8 +92,11 @@ SuspendedPageProxy::SuspendedPageProxy(WebPageProxy& page, Ref<WebProcessProxy>&
> 
> SuspendedPageProxy::~SuspendedPageProxy()
> {
>-    if (m_readyToUnsuspendHandler)
>-        m_readyToUnsuspendHandler(nullptr);
>+    if (m_readyToUnsuspendHandler) {
>+        RunLoop::main().dispatch([readyToUnsuspendHandler = WTFMove(m_readyToUnsuspendHandler)]() mutable {
>+            readyToUnsuspendHandler(nullptr);
>+        });
>+    }
> 
>     if (m_suspensionState == SuspensionState::Resumed)
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 194094: 360736