Attachment 360733 Details for Bug 191303 – Patch

[patch] Patch

bug-191303-20190131180938.patch (text/plain), 1.97 KB, created by darshan on 2019-01-31 09:09:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: darshan

Created: 2019-01-31 09:09:39 PST

Size: 1.97 KB

patch

obsolete

>Subversion Revision: 240715
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9b48791eb108c0b3fb78af7d052d7b6618f23b98..fd36cece87948276a50006c755cf111f67cab9a8 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-31  Darshan Kadu  <dkadu@igalia.com>
>+
>+        DumpRenderTree should report unknown options
>+        https://bugs.webkit.org/show_bug.cgi?id=191303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added RELEASE_ASSERT for DumpRenderTree/TestOptions.cpp DumpRenderTree
>+        to report unknown options.
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+
> 2019-01-30  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r240708.
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index c926612b1b1604a83ce2603bcda88ce3983d358e..5d13a683d1be24cd5fd204e161b52ce362f7b321 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -75,7 +75,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>         auto value = pairString.substr(equalsLocation + 1, pairEnd - (equalsLocation + 1));
>         if (key == "enableAttachmentElement")
>             enableAttachmentElement = parseBooleanTestHeaderValue(value);
>-        if (key == "useAcceleratedDrawing")
>+        else if (key == "useAcceleratedDrawing")
>             useAcceleratedDrawing = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIntersectionObserver")
>             enableIntersectionObserver = parseBooleanTestHeaderValue(value);
>@@ -111,6 +111,8 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             enableCSSLogical = parseBooleanTestHeaderValue(value);
>         else if (key == "internal:AdClickAttributionEnabled")
>             adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
>+        else
>+            RELEASE_ASSERT(false);
>         pairStart = pairEnd + 1;
>     }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 191303: 358263 | 358456 | 360474 | 360733 | 360737 | 360738 | 360743 | 360746 | 360760 | 360762 | 360768 | 360769 | 360779 | 360865 | 360913 | 361201 | 361302 | 361683 | 361687 | 362238