Attachment 360717 Details for Bug 194086 – Updated patch

[patch] Updated patch

wd-flaky.diff (text/plain), 2.02 KB, created by Carlos Garcia Campos on 2019-01-31 04:53:21 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-01-31 04:53:21 PST

Size: 2.02 KB

patch

obsolete

>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
>index c9f8359b88c..a3e787afe6e 100644
>--- a/Source/WebDriver/ChangeLog
>+++ b/Source/WebDriver/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GLIB] WebDriver: race condition when session starts
>+        https://bugs.webkit.org/show_bug.cgi?id=194086
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is causing flakiness in the bots, I can only reproduce it locally when my CPUs are at 100%. The thing
>+        is that sometimes we receive an empty target list right after the connection is established because
>+        RemoteInspector::setClient() calls pushListingsSoon() before a target has been registered. Most of the times the
>+        target is registered before the listing is pushed, but it can happen that when pushed, the listing is still
>+        empty. After the target is registered an empty target list means the connection was lost, so we clear the
>+        connection and target. We need to ensure we do that only after the target has been registered.
>+
>+        * glib/SessionHostGlib.cpp:
>+
> 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebDriver: POST commands require a valid parameters object
>diff --git a/Source/WebDriver/glib/SessionHostGlib.cpp b/Source/WebDriver/glib/SessionHostGlib.cpp
>index 34f9bca2b87..7a20b8941af 100644
>--- a/Source/WebDriver/glib/SessionHostGlib.cpp
>+++ b/Source/WebDriver/glib/SessionHostGlib.cpp
>@@ -331,9 +331,11 @@ void SessionHost::setTargetList(uint64_t connectionID, Vector<Target>&& targetLi
>     ASSERT(targetList.size() <= 1);
>     if (targetList.isEmpty()) {
>         m_target = Target();
>-        m_connectionID = 0;
>-        if (m_dbusConnection)
>-            g_dbus_connection_close(m_dbusConnection.get(), nullptr, nullptr, nullptr);
>+        if (m_connectionID) {
>+            if (m_dbusConnection)
>+                g_dbus_connection_close(m_dbusConnection.get(), nullptr, nullptr, nullptr);
>+            m_connectionID = 0;
>+        }
>         return;
>     }
>

Flags:

pnormand: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194086: 360716 | 360717