WebKit Bugzilla
Attachment 360688 Details for
Bug 194076
: Enable swipe tests on iOS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Enables the tests
bug-194076-20190130210959.patch (text/plain), 4.83 KB, created by
Ryosuke Niwa
on 2019-01-30 21:10:00 PST
(
hide
)
Description:
Enables the tests
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2019-01-30 21:10:00 PST
Size:
4.83 KB
patch
obsolete
>Subversion Revision: 240692 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 88f1c2a469357d641ff6c1f4007d6f403455ea22..c0ff020857be08291fff36d0225b73d49d56e325 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,17 @@ >+2019-01-30 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Enable swipe tests on iOS >+ https://bugs.webkit.org/show_bug.cgi?id=194076 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as >+ it causes a debug assertion failure in runUIScript. >+ >+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm: >+ (WTR::UIScriptController::beginBackSwipe): >+ (WTR::UIScriptController::completeBackSwipe): >+ > 2019-01-29 Youenn Fablet <youenn@apple.com> > > Adopt new SPI to evaluate server certificate trust >diff --git a/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm b/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm >index 027bc375682bed78d1be72ad62f6e185a705ae9b..4952765a0acfd3de3f182be28e2fe8e19395683b 100644 >--- a/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm >+++ b/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm >@@ -822,18 +822,12 @@ void UIScriptController::beginBackSwipe(JSValueRef callback) > { > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > [webView _beginBackSwipeForTesting]; >- >- unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); >- m_context->asyncTaskComplete(callbackID); > } > > void UIScriptController::completeBackSwipe(JSValueRef callback) > { > TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); > [webView _completeBackSwipeForTesting]; >- >- unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); >- m_context->asyncTaskComplete(callbackID); > } > > static BOOL forEachViewInHierarchy(UIView *view, void(^mapFunction)(UIView *subview, BOOL *stop)) >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 52873e6740e9fbafbaa9e84400e459a0554831c1..c60edeb1010f39352647d27a555d50eb226a0307 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,17 @@ >+2019-01-30 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Enable swipe tests on iOS >+ https://bugs.webkit.org/show_bug.cgi?id=194076 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Enabled tests in LayoutTests/swipe and added iOS specific results for the failing tests. >+ >+ * platform/ios/TestExpectations: >+ * platform/ios/swipe/basic-cached-back-swipe-expected.txt: Added. >+ * platform/ios/swipe/main-frame-pinning-requirement-expected.txt: Added. >+ * platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Added. >+ > 2019-01-29 Youenn Fablet <youenn@apple.com> > > Adopt new SPI to evaluate server certificate trust >diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations >index 842db9b047649962bcb5f14cb27c8da4f7e30c81..25f027064458b728218602900fb03a5806627980 100644 >--- a/LayoutTests/platform/ios/TestExpectations >+++ b/LayoutTests/platform/ios/TestExpectations >@@ -11,6 +11,7 @@ displaylists [ Pass ] > http/tests/quicklook [ Pass ] > media/ios [ Pass ] > quicklook [ Pass ] >+swipe [ Pass ] > > fast/text-autosizing/ios [ Pass ] > fast/zooming/ios [ Pass ] >diff --git a/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt b/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt >new file mode 100644 >index 0000000000000000000000000000000000000000..56f14de2d01ebca82a835e29c89bf74fd81f8a45 >--- /dev/null >+++ b/LayoutTests/platform/ios/swipe/basic-cached-back-swipe-expected.txt >@@ -0,0 +1,6 @@ >+startSwipeGesture >+didBeginSwipe >+completeSwipeGesture >+didEndSwipe >+didRemoveSwipeSnapshot >+ >diff --git a/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt b/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt >new file mode 100644 >index 0000000000000000000000000000000000000000..39b0d949ea3010b6f7a7cda953e6837ccbd3170c >--- /dev/null >+++ b/LayoutTests/platform/ios/swipe/main-frame-pinning-requirement-expected.txt >@@ -0,0 +1,7 @@ >+startSwipeGesture >+Failure. Should never begin a swipe, because we were in the middle of a scrolling gesture that started when the main frame was not pinned to the left. >+didEndSwipe >+completeSwipeGesture >+startSwipeGesture >+didRemoveSwipeSnapshot >+ >diff --git a/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt b/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt >new file mode 100644 >index 0000000000000000000000000000000000000000..56f14de2d01ebca82a835e29c89bf74fd81f8a45 >--- /dev/null >+++ b/LayoutTests/platform/ios/swipe/pushState-cached-back-swipe-expected.txt >@@ -0,0 +1,6 @@ >+startSwipeGesture >+didBeginSwipe >+completeSwipeGesture >+didEndSwipe >+didRemoveSwipeSnapshot >+
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194076
: 360688