Attachment 360660 Details for Bug 193979 – Fixes the test

[patch] Fixes the test

fix193979.patch (text/plain), 1.71 KB, created by Ryosuke Niwa on 2019-01-30 17:51:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-01-30 17:51:36 PST

Size: 1.71 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 88f1c2a4693..d66b18af44c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=193979
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the test for iOS. Make the test work with iOS UA string.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
>+
> 2019-01-29  Youenn Fablet  <youenn@apple.com>
> 
>         Adopt new SPI to evaluate server certificate trust
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
>index db166c22fa4..b8b6c6fbb80 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
>@@ -1139,8 +1139,8 @@ TEST(WebKit, WebsitePoliciesCustomJavaScriptUserAgent)
>     [schemeHandler addMappingFromURLString:@"test://www.apple.com/subframe.html" toData:customUserAgentSubFrameTestBytes];
>     [schemeHandler setTaskHandler:[](id <WKURLSchemeTask> task) {
>         auto* userAgentString = [task.request valueForHTTPHeaderField:@"User-Agent"];
>-        EXPECT_TRUE([userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]);
>-        EXPECT_TRUE([userAgentString hasSuffix:@"(KHTML, like Gecko)"]);
>+        EXPECT_TRUE([userAgentString hasPrefix:@"Mozilla/5.0 "]);
>+        EXPECT_TRUE([userAgentString containsString:@"(KHTML, like Gecko)"]);
>     }];
>     [configuration setURLSchemeHandler:schemeHandler.get() forURLScheme:@"test"];
>     [configuration preferences]._needsSiteSpecificQuirks = YES;

Actions: View | Formatted Diff | Diff

Attachments on bug 193979: 360660