Attachment 360644 Details for Bug 194058 – Patch

[patch] Patch

bug-194058-20190130163253.patch (text/plain), 1.99 KB, created by Keith Rollin on 2019-01-30 16:32:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-01-30 16:32:54 PST

Size: 1.99 KB

patch

obsolete

>Subversion Revision: 240722
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3bce74d3ab1dee288076f72589b212e164c4aa0e..78f5d9f3813777283a911eab23fa9cad4857cabf 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-01-30  Keith Rollin  <krollin@apple.com>
>+
>+        Add default constructor for NetworkActivityTracker
>+        https://bugs.webkit.org/show_bug.cgi?id=194058
>+        <rdar://problem/47685457>
>+
>+        Reviewed by Chris Dumez.
>+
>+        ResourceNetworkActivityTracker has a default constructor. It also has
>+        a NetworkActivityTracker data member, which does not have a default
>+        constructor. This will cause some compilers to complain -- they can't
>+        default-create a ResourceNetworkActivityTracker because they can't
>+        default-create its data members. Address this by adding a default
>+        constructor for NetworkActivityTracker.
>+
>+        * NetworkProcess/NetworkActivityTracker.h:
>+
> 2019-01-30  Antti Koivisto  <antti@apple.com>
> 
>         Crash in WebKit::RemoteLayerTreePropertyApplier::updateChildren
>diff --git a/Source/WebKit/NetworkProcess/NetworkActivityTracker.h b/Source/WebKit/NetworkProcess/NetworkActivityTracker.h
>index 88e3206b8bfc1ac0a8ee9947b07f9e6f82dcac29..f2a0694eeffbf1540d8a1eecd25ce6f44f1ce104 100644
>--- a/Source/WebKit/NetworkProcess/NetworkActivityTracker.h
>+++ b/Source/WebKit/NetworkProcess/NetworkActivityTracker.h
>@@ -64,7 +64,8 @@ public:
>         Failure,
>     };
> 
>-    NetworkActivityTracker(Label, Domain = Domain::WebKit);
>+    NetworkActivityTracker() = default;
>+    explicit NetworkActivityTracker(Label, Domain = Domain::WebKit);
>     ~NetworkActivityTracker();
> 
>     void setParent(NetworkActivityTracker&);
>@@ -77,8 +78,8 @@ public:
> 
> private:
> #if HAVE(NW_ACTIVITY)
>-    Domain m_domain;
>-    Label m_label;
>+    Domain m_domain { Domain::Invalid };
>+    Label m_label { Label::Invalid };
>     bool m_isCompleted { false };
>     RetainPtr<nw_activity_t> m_networkActivity;
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 194058: 360638 | 360644