Attachment 360643 Details for Bug 194064 – Patch

[patch] Patch

bug-194064-20190130163206.patch (text/plain), 2.66 KB, created by Tadeu Zagallo on 2019-01-30 16:32:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-01-30 16:32:26 PST

Size: 2.66 KB

patch

obsolete

>Subversion Revision: 240718
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 4c2d28bb7dc60281d9c1f45807de1efcc627fcf4..da3a637617f04f688f805ffe6597aac5459d93bc 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-30  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Fix `runJITThreadLimitTests` in testapi
>+        https://bugs.webkit.org/show_bug.cgi?id=194064
>+        <rdar://problem/46139147>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix typo where `targetNumberOfThreads` was not being used.
>+
>+        * API/tests/testapi.mm:
>+        (runJITThreadLimitTests):
>+
> 2019-01-30  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [JSC] Make global static variables "const" as much as possible
>diff --git a/Source/JavaScriptCore/API/tests/testapi.mm b/Source/JavaScriptCore/API/tests/testapi.mm
>index 2289e6e3489ae2f6cdcebf56562a3113d696855b..4b9f79820df1c81a0bf8ee78ada6ade8cc3d2f4d 100644
>--- a/Source/JavaScriptCore/API/tests/testapi.mm
>+++ b/Source/JavaScriptCore/API/tests/testapi.mm
>@@ -529,7 +529,7 @@ static void runJITThreadLimitTests()
>     auto testDFG = [] {
>         unsigned defaultNumberOfThreads = JSC::Options::numberOfDFGCompilerThreads();
>         unsigned targetNumberOfThreads = 1;
>-        unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:1];
>+        unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:targetNumberOfThreads];
>         checkResult(@"Initial number of DFG threads should be the value provided through Options", initialNumberOfThreads == defaultNumberOfThreads);
>         unsigned updatedNumberOfThreads = [JSVirtualMachine setNumberOfDFGCompilerThreads:initialNumberOfThreads];
>         checkResult(@"Number of DFG threads should have been updated", updatedNumberOfThreads == targetNumberOfThreads);
>@@ -538,7 +538,7 @@ static void runJITThreadLimitTests()
>     auto testFTL = [] {
>         unsigned defaultNumberOfThreads = JSC::Options::numberOfFTLCompilerThreads();
>         unsigned targetNumberOfThreads = 3;
>-        unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:1];
>+        unsigned initialNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:targetNumberOfThreads];
>         checkResult(@"Initial number of FTL threads should be the value provided through Options", initialNumberOfThreads == defaultNumberOfThreads);
>         unsigned updatedNumberOfThreads = [JSVirtualMachine setNumberOfFTLCompilerThreads:initialNumberOfThreads];
>         checkResult(@"Number of FTL threads should have been updated", updatedNumberOfThreads == targetNumberOfThreads);

Actions: View | Formatted Diff | Diff

Attachments on bug 194064: 360643