Attachment 360642 Details for Bug 194062 – Patch

[patch] Patch

bug-194062-20190130162326.patch (text/plain), 1.67 KB, created by Keith Rollin on 2019-01-30 16:23:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-01-30 16:23:26 PST

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 240722
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3820f7270aa170c5d914d40493e2732c61ffe324..c94f5fb765ee194ec46146fbd28f697adaf48341 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-30  Keith Rollin  <krollin@apple.com>
>+
>+        Use correct printf format specifier
>+        https://bugs.webkit.org/show_bug.cgi?id=194062
>+        <rdar://problem/47686167>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        LayoutTestSpellChecker.mm is trying to format a variable of type
>+        NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
>+        actually an unsigned long long. Fix this by formatting with %llu.
>+
>+        * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
>+        (-[LayoutTestTextCheckingResult description]):
>+
> 2019-01-30  Keith Rollin  <krollin@apple.com>
> 
>         [NSDragItem init] is unavailable
>diff --git a/Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm b/Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm
>index 8d83d8c407fcc7f1f659dad1b39987c070c32a7d..629d1dfcf237b7e6d948e5ad270c6eb1591fc4a9 100644
>--- a/Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm
>+++ b/Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm
>@@ -162,7 +162,7 @@ - (NSString *)replacementString
> 
> - (NSString *)description
> {
>-    return [NSString stringWithFormat:@"<%@ %p type=%tu range=[%tu, %tu] replacement='%@'>", self.class, self, _type, _range.location, _range.location + _range.length, _replacement.get()];
>+    return [NSString stringWithFormat:@"<%@ %p type=%llu range=[%tu, %tu] replacement='%@'>", self.class, self, _type, _range.location, _range.location + _range.length, _replacement.get()];
> }
> 
> @end

Actions: View | Formatted Diff | Diff

Attachments on bug 194062: 360642