WebKit Bugzilla
Attachment 360637 Details for
Bug 194057
: FloatWithRect has invalid and inaccessible default constructor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194057-20190130155827.patch (text/plain), 1.78 KB, created by
Keith Rollin
on 2019-01-30 15:58:27 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Rollin
Created:
2019-01-30 15:58:27 PST
Size:
1.78 KB
patch
obsolete
>Subversion Revision: 240722 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 49a9e39f093eacd78eac024d9145648c4015195d..2a0fe65166acaafe6cd62cbdf44a8775e71efb9f 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,21 @@ >+2019-01-30 Keith Rollin <krollin@apple.com> >+ >+ FloatWithRect has invalid and inaccessible default constructor >+ https://bugs.webkit.org/show_bug.cgi?id=194057 >+ <rdar://problem/47685211> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ FloatWithRect has a default constructor declared as 'default'. This >+ constructor is invalid because FloatWithRect has a data member that's >+ a reference that will not get initialized with this constructor. Since >+ it's invalid, and since it's private and not accessed by anything, >+ remove this constructor. >+ >+ No new tests since there should be no observable behavior difference. >+ >+ * rendering/line/LineLayoutState.h: >+ > 2019-01-30 Keith Rollin <krollin@apple.com> > > GCGamepad is deprecated >diff --git a/Source/WebCore/rendering/line/LineLayoutState.h b/Source/WebCore/rendering/line/LineLayoutState.h >index 792f54ae1a4be51c64f745351d70c49459f581b0..d0689b481f5782397971adefc9bd1f636b07d144 100644 >--- a/Source/WebCore/rendering/line/LineLayoutState.h >+++ b/Source/WebCore/rendering/line/LineLayoutState.h >@@ -54,8 +54,6 @@ public: > void adjustRect(const LayoutRect& rect) { m_rect = rect; } > > private: >- FloatWithRect() = default; >- > FloatWithRect(RenderBox& renderer) > : m_renderer(renderer) > , m_rect(LayoutRect(renderer.x() - renderer.marginLeft(), renderer.y() - renderer.marginTop(), renderer.width() + renderer.horizontalMarginExtent(), renderer.height() + renderer.verticalMarginExtent()))
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194057
: 360637