Attachment 360636 Details for Bug 194056 – Patch

[patch] Patch

bug-194056-20190130155309.patch (text/plain), 1.92 KB, created by Keith Rollin on 2019-01-30 15:53:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-01-30 15:53:10 PST

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 240722
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 344a12d1ab9bf3eaa533423b22c3b3671ad55390..49a9e39f093eacd78eac024d9145648c4015195d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-01-30  Keith Rollin  <krollin@apple.com>
>+
>+        GCGamepad is deprecated
>+        https://bugs.webkit.org/show_bug.cgi?id=194056
>+        <rdar://problem/47685010>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        GCGamepad is deprecated, resulting in compiler warnings. Address this
>+        for now by employing ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
>+
>+        No new tests since there should be no observable behavior difference.
>+
>+        * platform/gamepad/cocoa/GameControllerGamepad.mm:
>+        (WebCore::GameControllerGamepad::setupAsGamepad):
>+
> 2019-01-30  Keith Rollin  <krollin@apple.com>
> 
>         WebCore::WHLSL::AST::Expression copy constructor needs to be be default, not delete
>diff --git a/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm b/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
>index 2af9414b1d1cd034209dd4d4254fad54e2ae9b67..a1ff386866f99d16730d01423ac4790ff4d00a8e 100644
>--- a/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
>+++ b/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
>@@ -147,11 +147,13 @@ void GameControllerGamepad::setupAsGamepad()
> 
>     m_id = makeString(String(m_gcController.get().vendorName), " Gamepad"_s);
> 
>+    ALLOW_DEPRECATED_DECLARATIONS_BEGIN // GCGamepad
>     m_gamepad.get().valueChangedHandler = ^(GCGamepad *, GCControllerElement *) {
>         m_lastUpdateTime = MonotonicTime::now();
>         GameControllerGamepadProvider::singleton().gamepadHadInput(*this, m_hadButtonPresses);
>         m_hadButtonPresses = false;
>     };
>+    ALLOW_DEPRECATED_DECLARATIONS_END
> 
>     m_buttonValues.resize(6);
>     m_buttonValues[0] = m_extendedGamepad.get().buttonA.value;

Actions: View | Formatted Diff | Diff

Attachments on bug 194056: 360636