WebKit Bugzilla
Attachment 360635 Details for
Bug 194055
: WebCore::WHLSL::AST::Expression copy constructor needs to be be default, not delete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194055-20190130154757.patch (text/plain), 1.69 KB, created by
Keith Rollin
on 2019-01-30 15:47:58 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Rollin
Created:
2019-01-30 15:47:58 PST
Size:
1.69 KB
patch
obsolete
>Subversion Revision: 240722 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 0c2aef2bf0cf50d3a3a6b62ef94e4e9e2f422909..344a12d1ab9bf3eaa533423b22c3b3671ad55390 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,21 @@ >+2019-01-30 Keith Rollin <krollin@apple.com> >+ >+ WebCore::WHLSL::AST::Expression copy constructor needs to be be default, not delete >+ https://bugs.webkit.org/show_bug.cgi?id=194055 >+ <rdar://problem/47684570> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ WebCore::WHLSL::AST::Expression has a deleted copy constructor. >+ EnumerationMemberLiteral, a subclass, has a default copy constructor. >+ Some compilers may complain that the latter's c'tor can't access the >+ former's, because it doesn't exist. Fix this by marking Expression's >+ c'tor as default. >+ >+ No new tests since there should be no observable behavior difference. >+ >+ * Modules/webgpu/WHLSL/AST/WHLSLExpression.h: >+ > 2019-01-30 Dean Jackson <dino@apple.com> > > PointerEvents - tiltX and tiltY are reversed >diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >index 01f2ffb806a0576bc6056e061ab172be264616ee..4edbb75143e511f008cf5e600971e3b96be83634 100644 >--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h >@@ -49,7 +49,7 @@ public: > > virtual ~Expression() = default; > >- Expression(const Expression&) = delete; >+ Expression(const Expression&) = default; > Expression(Expression&&) = default; > > Expression& operator=(const Expression&) = default;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194055
: 360635