Attachment 360619 Details for Bug 194037 – Patch for landing

[patch] Patch for landing

bug-194037-20190130140822.patch (text/plain), 1.80 KB, created by Tadeu Zagallo on 2019-01-30 14:08:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-01-30 14:08:42 PST

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 240718
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 4c2d28bb7dc60281d9c1f45807de1efcc627fcf4..bd92f9ad706ed18fa389d47d0d7337004da47f31 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-30  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Remove assertion that CachedSymbolTables should have no RareData
>+        https://bugs.webkit.org/show_bug.cgi?id=194037
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It turns out that we don't need to cache the SymbolTableRareData, but
>+        we should not assert that it's empty.
>+
>+        * runtime/CachedTypes.cpp:
>+        (JSC::CachedSymbolTable::encode):
>+
> 2019-01-30  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [JSC] Make global static variables "const" as much as possible
>diff --git a/Source/JavaScriptCore/runtime/CachedTypes.cpp b/Source/JavaScriptCore/runtime/CachedTypes.cpp
>index 9d9554c5a784e62cab5d0d132a03fc9d25039b3a..05e8f0786320522d682e7de9569e30a0a2fbab72 100644
>--- a/Source/JavaScriptCore/runtime/CachedTypes.cpp
>+++ b/Source/JavaScriptCore/runtime/CachedTypes.cpp
>@@ -906,7 +906,6 @@ class CachedSymbolTable : public CachedObject<SymbolTable> {
> public:
>     void encode(Encoder& encoder, const SymbolTable& symbolTable)
>     {
>-        ASSERT(!symbolTable.m_rareData);
>         m_map.encode(encoder, symbolTable.m_map);
>         m_maxScopeOffset = symbolTable.m_maxScopeOffset;
>         m_usesNonStrictEval = symbolTable.m_usesNonStrictEval;
>@@ -935,8 +934,6 @@ private:
>     unsigned m_usesNonStrictEval : 1;
>     unsigned m_nestedLexicalScope : 1;
>     unsigned m_scopeType : 3;
>-    // FIXME: do we need to cached this eventually?
>-    // CachedPtr<SymbolTableRareData> rareData;
>     CachedPtr<CachedScopedArgumentsTable> m_arguments;
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194037: 360612 | 360619 | 360629