Attachment 360615 Details for Bug 194045 – Patch

[patch] Patch

bug-194045-20190130135252.patch (text/plain), 1.42 KB, created by Tadeu Zagallo on 2019-01-30 13:53:12 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-01-30 13:53:12 PST

Size: 1.42 KB

patch

obsolete

>Subversion Revision: 240718
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 4c2d28bb7dc60281d9c1f45807de1efcc627fcf4..63d3f953a5533365ca14a67b2c9f1309ebf57a98 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-30  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        CachedBytecode's move constructor should not call `freeDataIfOwned`
>+        https://bugs.webkit.org/show_bug.cgi?id=194045
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        That might result in freeing a garbage value
>+
>+        * parser/SourceProvider.h:
>+        (JSC::CachedBytecode::CachedBytecode):
>+
> 2019-01-30  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [JSC] Make global static variables "const" as much as possible
>diff --git a/Source/JavaScriptCore/parser/SourceProvider.h b/Source/JavaScriptCore/parser/SourceProvider.h
>index a5e825b7727115429f0a74d2e5190b2addb3f59e..3778bf941ad7fac864d6ca780a06d8289e91ae4c 100644
>--- a/Source/JavaScriptCore/parser/SourceProvider.h
>+++ b/Source/JavaScriptCore/parser/SourceProvider.h
>@@ -67,7 +67,10 @@ namespace JSC {
> 
>         CachedBytecode(CachedBytecode&& other)
>         {
>-            *this = WTFMove(other);
>+            m_owned = other.m_owned;
>+            m_size = other.m_size;
>+            m_data = other.m_data;
>+            other.m_owned = false;
>         }
> 
>         CachedBytecode& operator=(CachedBytecode&& other)

Actions: View | Formatted Diff | Diff

Attachments on bug 194045: 360615