Attachment 360600 Details for Bug 194032 – Patch

[patch] Patch

bug-194032-20190130111916.patch (text/plain), 3.10 KB, created by Dean Jackson on 2019-01-30 11:19:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2019-01-30 11:19:17 PST

Size: 3.10 KB

patch

obsolete

>Subversion Revision: 240661
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 27bfb8593ba2423d5407632c747921f4481283a7..87170e1508a8db489cb04b2af5df2a52934ad549 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-30  Dean Jackson  <dino@apple.com>
>+
>+        PointerEvents - tiltX and tiltY are reversed
>+        https://bugs.webkit.org/show_bug.cgi?id=194032
>+        <rdar://problem/47674184>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        I got tiltX and tiltY the wrong way around.
>+
>+        * dom/ios/PointerEventIOS.cpp: Flip the values.
>+
> 2019-01-29  Chris Dumez  <cdumez@apple.com>
> 
>         Make sure WTF::generateObjectIdentifier() internal counter does not get duplicated
>diff --git a/Source/WebCore/dom/ios/PointerEventIOS.cpp b/Source/WebCore/dom/ios/PointerEventIOS.cpp
>index 2112ee84a6f8912adf4f8c66bc6083abe67cbac0..805ad348c5da94b4ae28e783212e21a057c01915 100644
>--- a/Source/WebCore/dom/ios/PointerEventIOS.cpp
>+++ b/Source/WebCore/dom/ios/PointerEventIOS.cpp
>@@ -77,8 +77,8 @@ PointerEvent::PointerEvent(const AtomicString& type, const PlatformTouchEvent& e
>     double azimuthAngle = event.azimuthAngleAtIndex(index);
>     double altitudeAngle = event.altitudeAngleAtIndex(index);
> 
>-    m_tiltX = round(sin(azimuthAngle) * cos(altitudeAngle) * 90);
>-    m_tiltY = round(cos(azimuthAngle) * cos(altitudeAngle) * 90);
>+    m_tiltX = round(cos(azimuthAngle) * cos(altitudeAngle) * 90);
>+    m_tiltY = round(sin(azimuthAngle) * cos(altitudeAngle) * 90);
> }
> 
> } // namespace WebCore
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9261b6b474a7ea86155d9fb536b175274667e94c..297bde3dc2417fda42d0430ea55fd1ce023d50f8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-30  Dean Jackson  <dino@apple.com>
>+
>+        PointerEvents - tiltX and tiltY are reversed
>+        https://bugs.webkit.org/show_bug.cgi?id=194032
>+        <rdar://problem/47674184>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * pointerevents/ios/pointer-events-dispatch-on-stylus.html:
>+
> 2019-01-28  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: provide a way to edit page WebRTC settings on a remote target
>diff --git a/LayoutTests/pointerevents/ios/pointer-events-dispatch-on-stylus.html b/LayoutTests/pointerevents/ios/pointer-events-dispatch-on-stylus.html
>index b6015066d3295e3469e40153a026449c4ba92471..f522931497881db9b50bc5bb321d13101ab1f273 100644
>--- a/LayoutTests/pointerevents/ios/pointer-events-dispatch-on-stylus.html
>+++ b/LayoutTests/pointerevents/ios/pointer-events-dispatch-on-stylus.html
>@@ -23,8 +23,8 @@ target_test((target, test) => {
>         assert_equals(event.clientY, 50);
>         assert_equals(event.pointerType, "pen");
>         assert_equals(event.pressure, 0.75);
>-        assert_approx_equals(event.tiltX, 20, 1);
>-        assert_approx_equals(event.tiltY, 75, 1);
>+        assert_approx_equals(event.tiltX, 75, 1);
>+        assert_approx_equals(event.tiltY, 20, 1);
>         test.done();
>     });
>     ui.beginStylus({ x: 50, y: 50, pressure: 0.75, azimuthAngle: fifteenDegrees, altitudeAngle: thirtyDegrees });

Flags:

jonlee: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194032: 360600