WebKit Bugzilla
Attachment 360594 Details for
Bug 194029
: Web Inspector: Uncaught Exception: null is not an object (evaluating 'url.startsWith')
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194029-20190130104713.patch (text/plain), 1.80 KB, created by
Devin Rousso
on 2019-01-30 10:47:14 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-01-30 10:47:14 PST
Size:
1.80 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 1acf60b95684b1c7870b1c64f7e8eda8b9f964d6..32bd8cbef59ee765c6dc707bdf79e7af788bf946 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-30 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Uncaught Exception: null is not an object (evaluating 'url.startsWith') >+ https://bugs.webkit.org/show_bug.cgi?id=194029 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/ConsoleMessageView.js: >+ (WI.ConsoleMessageView.prototype._appendLocationLink): >+ > 2019-01-28 Joseph Pecoraro <pecoraro@apple.com> > > Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler >diff --git a/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js b/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js >index 7aecedb8d85d7f9795e3d4dbce0b1103b384c565..de6ec24e9911444115e0877812b80ede5e009f3a 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js >@@ -358,7 +358,7 @@ WI.ConsoleMessageView = class ConsoleMessageView extends WI.Object > if (result === WI.RemoteObject.SourceCodeLocationPromise.NoSourceFound || result === WI.RemoteObject.SourceCodeLocationPromise.MissingObjectId) > return; > >- var link = this._linkifyLocation(result.sourceCode.url, result.lineNumber, result.columnNumber); >+ var link = this._linkifyLocation(result.sourceCode.sourceURL || result.sourceCode.url, result.lineNumber, result.columnNumber); > link.classList.add("console-message-location"); > > if (this._element.hasChildNodes())
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194029
: 360594