WebKit Bugzilla
Attachment 360589 Details for
Bug 194025
: Make VCP VTB SPI check compile time and disable it by default until ready
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch (text/plain), 2.04 KB, created by
youenn fablet
on 2019-01-30 10:13:51 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2019-01-30 10:13:51 PST
Size:
2.04 KB
patch
obsolete
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog >index 9bccbbe3dcd..bb5af87afda 100644 >--- a/Source/ThirdParty/libwebrtc/ChangeLog >+++ b/Source/ThirdParty/libwebrtc/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-30 Youenn Fablet <youenn@apple.com> >+ >+ Invalidate VT testing compression session in VCP detection routine >+ https://bugs.webkit.org/show_bug.cgi?id=194025 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: >+ (isSupportingH264RTVC): We should use VTCompressionSessionInvalidate instead of VCPCompressionSessionInvalidate. >+ > 2019-01-29 Youenn Fablet <youenn@apple.com> > > Adopt new VCP SPI >diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm >index 4499e1ccd95..c31111a276f 100644 >--- a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm >+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm >@@ -87,12 +87,12 @@ bool isSupportingH264RTVC() > > CFDictionarySetValue(encoderSpecs, kVTVideoEncoderList_EncoderID, CFSTR("com.apple.videotoolbox.videoencoder.h264.rtvc")); > >- CompressionSessionRef compressionSession = nullptr; >+ VTCompressionSessionRef compressionSession = nullptr; > OSStatus status = VTCompressionSessionCreate(nullptr, 320, 240, kCMVideoCodecType_H264, >- encoderSpecs, sourceAttributes, nullptr, testCompressionOutputCallback, nullptr, reinterpret_cast<VTCompressionSessionRef*>(&compressionSession)); >+ encoderSpecs, sourceAttributes, nullptr, testCompressionOutputCallback, nullptr, &compressionSession); > > if (compressionSession) { >- CompressionSessionInvalidate(compressionSession); >+ VTCompressionSessionInvalidate(compressionSession); > CFRelease(compressionSession); > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194025
:
360589