Attachment 360560 Details for Bug 194006 – patch

[patch] patch

patch (text/plain), 4.13 KB, created by chris fleizach on 2019-01-29 23:48:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2019-01-29 23:48:50 PST

Size: 4.13 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 240705)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-01-29  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: Role=switch not returning correct accessibilityValue
>+        https://bugs.webkit.org/show_bug.cgi?id=194006
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Return the toggle state of a role=switch element.        
>+
>+        Test: accessibility/ios-simulator/role-switch.html
>+
>+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
>+        (-[WebAccessibilityObjectWrapper accessibilityValue]):
>+
> 2019-01-29  Eric Carlson  <eric.carlson@apple.com>
> 
>         [MSE] add more source buffer logging
>Index: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
>===================================================================
>--- Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	(revision 240558)
>+++ Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	(working copy)
>@@ -1404,7 +1404,7 @@
>         return value;
>     
>     AccessibilityRole role = m_object->roleValue();
>-    if (m_object->isCheckboxOrRadio() || role == AccessibilityRole::MenuItemCheckbox || role == AccessibilityRole::MenuItemRadio) {
>+    if (m_object->isCheckboxOrRadio() || role == AccessibilityRole::MenuItemCheckbox || role == AccessibilityRole::MenuItemRadio || role == AccessibilityRole::Switch) {
>         switch (m_object->checkboxOrRadioValue()) {
>         case AccessibilityButtonState::Off:
>             return [NSString stringWithFormat:@"%d", 0];
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 240558)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-01-29  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: Role=switch not returning correct accessibilityValue
>+        https://bugs.webkit.org/show_bug.cgi?id=194006
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/ios-simulator/role-switch-expected.txt: Added.
>+        * accessibility/ios-simulator/role-switch.html: Added.
>+
> 2019-01-26  Simon Fraser  <simon.fraser@apple.com>
> 
>         Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node
>Index: LayoutTests/accessibility/ios-simulator/role-switch-expected.txt
>===================================================================
>--- LayoutTests/accessibility/ios-simulator/role-switch-expected.txt	(nonexistent)
>+++ LayoutTests/accessibility/ios-simulator/role-switch-expected.txt	(working copy)
>@@ -0,0 +1,12 @@
>+
>+This test thats accessibilityValue is correct for role=switch.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+PASS element.stringValue is 'AXValue: 1'
>+PASS element.stringValue is 'AXValue: 0'
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>Index: LayoutTests/accessibility/ios-simulator/role-switch.html
>===================================================================
>--- LayoutTests/accessibility/ios-simulator/role-switch.html	(nonexistent)
>+++ LayoutTests/accessibility/ios-simulator/role-switch.html	(working copy)
>@@ -0,0 +1,38 @@
>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
>+<html>
>+<head>
>+<script src="../../resources/js-test-pre.js"></script>
>+<script>
>+var successfullyParsed = false;
>+if (window.testRunner)
>+   testRunner.dumpAsText();
>+</script>
>+</head>
>+<body>
>+
>+<button role="switch" aria-checked="true" id="switch" class="switch">
>+
>+<p id="description"></p>
>+<div id="console"></div>
>+
>+<script>
>+
>+    description("This test thats accessibilityValue is correct for role=switch.");
>+
>+    if (window.accessibilityController) {
>+
>+        var element = accessibilityController.accessibleElementById("switch");
>+        shouldBe("element.stringValue", "'AXValue: 1'");
>+
>+        document.getElementById("switch").ariaChecked = false;
>+        shouldBe("element.stringValue", "'AXValue: 0'");
>+    }
>+
>+    successfullyParsed = true;
>+</script>
>+
>+<script src="../../resources/js-test-post.js"></script>
>+
>+</body>
>+</html>
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 194006: 360560