Attachment 360543 Details for Bug 194000 – Patch for landing

[patch] Patch for landing

bug-194000-20190129202550.patch (text/plain), 1.63 KB, created by Keith Miller on 2019-01-29 20:25:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2019-01-29 20:25:52 PST

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 240702
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 30c21ef74a1fcb9e77e5d1ce7c4906bba4874776..1bbad59724608212a7ec1fabed8c6a8f24e3f5f4 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-29  Keith Miller  <keith_miller@apple.com>
>+
>+        Remove default constructor from LLIntPrototypeLoadAdaptiveStructureWatchpoint
>+        https://bugs.webkit.org/show_bug.cgi?id=194000
>+        <rdar://problem/47642894>
>+
>+        Reviewed by Mark Lam.
>+
>+        default constructor is unused and
>+        LLIntPrototypeLoadAdaptiveStructureWatchpoint has a reference
>+        data member which causes sadness.
>+
>+        * bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
>+
> 2019-01-29  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         Remove FIXME for Annex B.3.5's "for-of var" subcase.
>diff --git a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h
>index 27a8e317f463a67d5d3e2686aa8d4433d8aab447..0a1730af7ab91604dec51800e025c74bff876e60 100644
>--- a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h
>+++ b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h
>@@ -33,7 +33,6 @@ namespace JSC {
> 
> class LLIntPrototypeLoadAdaptiveStructureWatchpoint : public Watchpoint {
> public:
>-    LLIntPrototypeLoadAdaptiveStructureWatchpoint() = default;
>     LLIntPrototypeLoadAdaptiveStructureWatchpoint(const ObjectPropertyCondition&, OpGetById::Metadata&);
> 
>     void install(VM&);

Actions: View | Formatted Diff | Diff

Attachments on bug 194000: 360541 | 360542 | 360543