WebKit Bugzilla
Attachment 360541 Details for
Bug 194000
: Remove default constructor from LLIntPrototypeLoadAdaptiveStructureWatchpoint
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194000-20190129201246.patch (text/plain), 2.79 KB, created by
Keith Miller
on 2019-01-29 20:12:49 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Miller
Created:
2019-01-29 20:12:49 PST
Size:
2.79 KB
patch
obsolete
>Subversion Revision: 240702 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 30c21ef74a1fcb9e77e5d1ce7c4906bba4874776..b415a9cecd06a620d1eb15463d45cca9ca73c7b8 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-01-29 Keith Miller <keith_miller@apple.com> >+ >+ Fix default constructor with reference member >+ https://bugs.webkit.org/show_bug.cgi?id=194000 >+ <rdar://problem/47642894> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp: >+ (JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint): >+ (JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal): >+ * bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h: >+ > 2019-01-29 Ross Kirsling <ross.kirsling@sony.com> > > Remove FIXME for Annex B.3.5's "for-of var" subcase. >diff --git a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp >index 6beddf9ccd62e6716ab4086ef018135f23ce2f50..aa1997d2718f85e467aa5b744e3301f6f7268db8 100644 >--- a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp >+++ b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp >@@ -34,7 +34,7 @@ namespace JSC { > > LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint(const ObjectPropertyCondition& key, OpGetById::Metadata& getByIdMetadata) > : m_key(key) >- , m_getByIdMetadata(getByIdMetadata) >+ , m_getByIdMetadata(&getByIdMetadata) > { > RELEASE_ASSERT(key.watchingRequiresStructureTransitionWatchpoint()); > RELEASE_ASSERT(!key.watchingRequiresReplacementWatchpoint()); >@@ -54,7 +54,7 @@ void LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal(VM& vm, const F > return; > } > >- clearLLIntGetByIdCache(m_getByIdMetadata); >+ clearLLIntGetByIdCache(*m_getByIdMetadata); > } > > void LLIntPrototypeLoadAdaptiveStructureWatchpoint::clearLLIntGetByIdCache(OpGetById::Metadata& metadata) >diff --git a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h >index 27a8e317f463a67d5d3e2686aa8d4433d8aab447..e6a800902ea533ac648a58020e267e3903833cf0 100644 >--- a/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h >+++ b/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h >@@ -47,7 +47,7 @@ protected: > > private: > ObjectPropertyCondition m_key; >- OpGetById::Metadata& m_getByIdMetadata; >+ OpGetById::Metadata* m_getByIdMetadata { nullptr }; > }; > > } // namespace JSC
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194000
:
360541
|
360542
|
360543