WebKit Bugzilla
Attachment 360525 Details for
Bug 193996
: iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for landing
bug-193996-20190129163940.patch (text/plain), 1.47 KB, created by
Ryosuke Niwa
on 2019-01-29 16:39:41 PST
(
hide
)
Description:
Patch for landing
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2019-01-29 16:39:41 PST
Size:
1.47 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 240691) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2019-01-29 Ryosuke Niwa <rniwa@webkit.org> >+ >+ iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list >+ https://bugs.webkit.org/show_bug.cgi?id=193996 >+ >+ Reviewed by Wenson Hsieh. >+ >+ Added a missing nullptr check. >+ >+ * WebProcess/WebPage/ios/WebPageIOS.mm: >+ (WebKit::WebPage::getPositionInformation): >+ > 2019-01-29 Youenn Fablet <youenn@apple.com> > > Adopt new SPI to evaluate server certificate trust >Index: Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm >=================================================================== >--- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (revision 240646) >+++ Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (working copy) >@@ -2248,7 +2248,7 @@ void WebPage::getPositionInformation(con > > // Prevent the callout bar from showing when tapping on the datalist button. > #if ENABLE(DATALIST_ELEMENT) >- if (is<HTMLInputElement>(*hitNode)) { >+ if (is<HTMLInputElement>(hitNode)) { > const HTMLInputElement& input = downcast<HTMLInputElement>(*hitNode); > if (input.list()) { > HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193996
:
360524
| 360525