Attachment 360508 Details for Bug 193986 – Patch

[patch] Patch

patch.txt (text/plain), 4.08 KB, created by Nikita Vasilyev on 2019-01-29 15:25:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-01-29 15:25:34 PST

Size: 4.08 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index df5bb59daba..de162eddb85 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-29  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Enabled Changes panel in Elements tab by default
>+        https://bugs.webkit.org/show_bug.cgi?id=193986
>+        <rdar://problem/47647683>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Setting.js:
>+        * UserInterface/Views/ElementsTabContentView.js:
>+        (WI.ElementsTabContentView):
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
>+
> 2019-01-29  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: enable computed style cascades by default
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>index a85b16978f9..fa21f5e23f8 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Setting.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>@@ -152,7 +152,6 @@ WI.settings = {
>     zoomFactor: new WI.Setting("zoom-factor", 1),
> 
>     // Experimental
>-    experimentalEnableChangesPanel: new WI.Setting("experimental-enable-changes-panel", false),
>     experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
>     experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
>     experimentalEnableAuditTab: new WI.Setting("experimental-enable-audit-tab", false),
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>index 2eb912ab40f..b9cfef125c5 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>@@ -29,10 +29,7 @@ WI.ElementsTabContentView = class ElementsTabContentView extends WI.ContentBrows
>     {
>         let tabBarItem = WI.GeneralTabBarItem.fromTabInfo(WI.ElementsTabContentView.tabInfo());
> 
>-        let detailsSidebarPanelConstructors = [WI.RulesStyleDetailsSidebarPanel, WI.ComputedStyleDetailsSidebarPanel];
>-        if (WI.settings.experimentalEnableChangesPanel.value)
>-            detailsSidebarPanelConstructors.push(WI.ChangesDetailsSidebarPanel);
>-        detailsSidebarPanelConstructors.push(WI.DOMNodeDetailsSidebarPanel);
>+        let detailsSidebarPanelConstructors = [WI.RulesStyleDetailsSidebarPanel, WI.ComputedStyleDetailsSidebarPanel, WI.ChangesDetailsSidebarPanel, WI.DOMNodeDetailsSidebarPanel];
>         if (window.LayerTreeAgent)
>             detailsSidebarPanelConstructors.push(WI.LayerTreeDetailsSidebarPanel);
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index b440d77a7a0..e97196afa62 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -253,12 +253,6 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
> 
>         let initialValues = new Map;
> 
>-        if (window.CSSAgent) {
>-            let group = experimentalSettingsView.addGroup(WI.UIString("Styles Sidebar:"));
>-            group.addSetting(WI.settings.experimentalEnableChangesPanel, WI.UIString("Enable Changes Panel"));
>-            experimentalSettingsView.addSeparator();
>-        }
>-
>         if (window.LayerTreeAgent) {
>             experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
>             experimentalSettingsView.addSeparator();
>@@ -289,7 +283,6 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
>             });
>         }
> 
>-        listenForChange(WI.settings.experimentalEnableChangesPanel);
>         listenForChange(WI.settings.experimentalEnableLayersTab);
>         listenForChange(WI.settings.experimentalEnableNewTabBar);
>

Flags:

mattbaker: review+
nvasilyev: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 193986: 360508 | 360526