Attachment 360506 Details for Bug 193985 – Patch

[patch] Patch

bug-193985-20190129151658.patch (text/plain), 2.09 KB, created by Brent Fulgham on 2019-01-29 15:16:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2019-01-29 15:16:59 PST

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 240676
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f4cd4df1344061dc8d94857620c0afd3ebe69525..35903b6b98496a97ea4f1ff840a2cbed23074949 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-29  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Make sure we have a frame before trying to access its loader 
>+        https://bugs.webkit.org/show_bug.cgi?id=193985
>+        <rdar://problem/47618239>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * loader/ResourceLoadObserver.cpp:
>+        (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
>+
> 2019-01-29  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] Fix and add validation to WebGPURenderPipeline and MTLVertexDescriptor
>diff --git a/Source/WebCore/loader/ResourceLoadObserver.cpp b/Source/WebCore/loader/ResourceLoadObserver.cpp
>index 01d33d6be46be061d2d27f12f0b4da8f3037277d..a363155017020c977f5de547c5e9b8216ade29e0 100644
>--- a/Source/WebCore/loader/ResourceLoadObserver.cpp
>+++ b/Source/WebCore/loader/ResourceLoadObserver.cpp
>@@ -214,11 +214,12 @@ void ResourceLoadObserver::logUserInteractionWithReducedTimeResolution(const Doc
>     statistics.mostRecentUserInteractionTime = newTime;
> 
> #if ENABLE(RESOURCE_LOAD_STATISTICS)
>-    if (auto* opener = document.frame()->loader().opener()) {
>-        if (auto* openerDocument = opener->document()) {
>-            if (auto* openerFrame = openerDocument->frame()) {
>-                if (auto openerPageID = openerFrame->loader().client().pageID()) {
>-                    requestStorageAccessUnderOpener(domain, openerPageID.value(), *openerDocument);
>+    if (auto* frame = document.frame()) {
>+        if (auto* opener = frame->loader().opener()) {
>+            if (auto* openerDocument = opener->document()) {
>+                if (auto* openerFrame = openerDocument->frame()) {
>+                    if (auto openerPageID = openerFrame->loader().client().pageID())
>+                        requestStorageAccessUnderOpener(domain, openerPageID.value(), *openerDocument);
>                 }
>             }
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 193985: 360506