WebKit Bugzilla
Attachment 360493 Details for
Bug 193980
: [JSC] FTL should handle LocalAllocator*
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193980-20190129134030.patch (text/plain), 1.61 KB, created by
Yusuke Suzuki
on 2019-01-29 13:40:30 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2019-01-29 13:40:30 PST
Size:
1.61 KB
patch
obsolete
>Subversion Revision: 240677 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 2455a8ff4d34701536d4b4778a9df58a32153651..6e1f67aa6f331c85f30e6ac6c1e48c6845a9ba27 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-01-29 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [JSC] FTL should handle LocalAllocator* >+ https://bugs.webkit.org/show_bug.cgi?id=193980 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator* >+ because the FTL still use the incoming value as 32bit integer there. >+ >+ * ftl/FTLLowerDFGToB3.cpp: >+ (JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell): >+ > 2019-01-29 Keith Rollin <krollin@apple.com> > > Add .xcfilelists to Run Script build phases >diff --git a/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp b/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp >index 078e12aeadfb45cce300950449539ab7a9d20507..4f3a5a054b58b145c70c8a4a6a4af6cc0f5a0807 100644 >--- a/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp >+++ b/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp >@@ -13041,7 +13041,7 @@ class LowerDFGToB3 { > LValue allocateHeapCell(LValue allocator, LBasicBlock slowPath) > { > JITAllocator actualAllocator; >- if (allocator->hasInt32()) >+ if (allocator->hasIntPtr()) > actualAllocator = JITAllocator::constant(Allocator(bitwise_cast<LocalAllocator*>(allocator->asIntPtr()))); > else > actualAllocator = JITAllocator::variable();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
saam
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193980
: 360493