Attachment 360474 Details for Bug 191303 – Patch

[patch] Patch

bug-191303-20190129194243.patch (text/plain), 1.92 KB, created by darshan on 2019-01-29 10:42:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: darshan

Created: 2019-01-29 10:42:44 PST

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 239610
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 48d642a731de0cb5defc0e961da2451d0442a9e7..1e70536831a93e736eb381d3ac60ca5575ef3c1c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-29  Darshan Kadu  <dkadu@igalia.com>
>+
>+        DumpRenderTree should report unknown options
>+        https://bugs.webkit.org/show_bug.cgi?id=191303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added RELEASE_ASSERT for DumpRenderTree to report unknown options
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+
> 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         test262-runner misbehaves when test file YAML has a trailing space
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index 82d87e13ac80ee46b570964983579368e1ad2978..95bb0145043631358f2355d083def3cf9fabce71 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -75,7 +75,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>         auto value = pairString.substr(equalsLocation + 1, pairEnd - (equalsLocation + 1));
>         if (key == "enableAttachmentElement")
>             enableAttachmentElement = parseBooleanTestHeaderValue(value);
>-        if (key == "useAcceleratedDrawing")
>+        else if (key == "useAcceleratedDrawing")
>             useAcceleratedDrawing = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIntersectionObserver")
>             enableIntersectionObserver = parseBooleanTestHeaderValue(value);
>@@ -107,6 +107,9 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             jscOptions = value;
>         else if (key == "experimental:WebGPUEnabled")
>             enableWebGPU = parseBooleanTestHeaderValue(value);
>+        else
>+            RELEASE_ASSERT(false);
>+        
>         pairStart = pairEnd + 1;
>     }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 191303: 358263 | 358456 | 360474 | 360733 | 360737 | 360738 | 360743 | 360746 | 360760 | 360762 | 360768 | 360769 | 360779 | 360865 | 360913 | 361201 | 361302 | 361683 | 361687 | 362238