Attachment 360449 Details for Bug 193957 – Patch for landing

[patch] Patch for landing

bug-193957-20190129000235.patch (text/plain), 1.51 KB, created by Keith Miller on 2019-01-29 00:02:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2019-01-29 00:02:36 PST

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 240644
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index ad050a70c2e964c68aaa131679acf92633ffeefd..cc1ecfcdffefdad8a525ab676f7a833420db0f9e 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-28  Keith Miller  <keith_miller@apple.com>
>+
>+        mul32 should convert powers of 2 to an lshift
>+        https://bugs.webkit.org/show_bug.cgi?id=193957
>+
>+        Reviewed by Yusuke Suzuki.
>+
>+        * assembler/MacroAssembler.h:
>+        (JSC::MacroAssembler::mul32):
>+
> 2019-01-28  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: provide a way to edit page WebRTC settings on a remote target
>diff --git a/Source/JavaScriptCore/assembler/MacroAssembler.h b/Source/JavaScriptCore/assembler/MacroAssembler.h
>index 3a72c2792240ab6865644570960510e6e1020d88..6f9dfeae84e583e2ae18bfc8fd6305d0f79fe00d 100644
>--- a/Source/JavaScriptCore/assembler/MacroAssembler.h
>+++ b/Source/JavaScriptCore/assembler/MacroAssembler.h
>@@ -1904,6 +1904,15 @@ public:
>         urshift32(src, trustedImm32ForShift(amount), dest);
>     }
> 
>+    void mul32(TrustedImm32 imm, RegisterID src, RegisterID dest)
>+    {
>+        if (hasOneBitSet(imm.m_value)) {
>+            lshift32(src, TrustedImm32(getLSBSet(imm.m_value)), dest);
>+            return;
>+        }
>+        MacroAssemblerBase::mul32(imm, src, dest);
>+    }
>+
>     // If the result jump is taken that means the assert passed.
>     void jitAssert(const WTF::ScopedLambda<Jump(void)>&);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193957: 360441 | 360446 | 360447 | 360448 | 360449 | 360613 | 360614 | 360617