Attachment 360434 Details for Bug 193952 – Patch

[patch] Patch

Patch.txt (text/plain), 1.35 KB, created by zalan on 2019-01-28 21:25:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-01-28 21:25:37 PST

Size: 1.35 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d4053e12d06..893fa7ca6c9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-28  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][BFC][MarginCollapsing] Anonymous block container's margin before does not collapse with previous inflow sibling margin after.
>+        https://bugs.webkit.org/show_bug.cgi?id=193952
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * layout/blockformatting/BlockMarginCollapse.cpp:
>+        (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
>+
> 2019-01-28  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
>diff --git a/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp b/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp
>index cb62a120845..4d50145d75e 100644
>--- a/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp
>+++ b/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp
>@@ -151,6 +151,9 @@ bool BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSi
> {
>     ASSERT(layoutBox.isBlockLevelBox());
> 
>+    if (layoutBox.isAnonymous())
>+        return false;
>+
>     if (!layoutBox.previousInFlowSibling())
>         return false;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193952: 360434