WebKit Bugzilla
Attachment 360433 Details for
Bug 193948
: [LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193948-20190128211503.patch (text/plain), 1.76 KB, created by
zalan
on 2019-01-28 21:15:15 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
zalan
Created:
2019-01-28 21:15:15 PST
Size:
1.76 KB
patch
obsolete
>Subversion Revision: 240602 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index dad7450a94448006eb972a12262a27fec00c400f..d4053e12d06ba64c5904f3893bef31d8f59bbfa9 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-28 Zalan Bujtas <zalan@apple.com> >+ >+ [LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough >+ https://bugs.webkit.org/show_bug.cgi?id=193948 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight(). >+ >+ * layout/blockformatting/BlockMarginCollapse.cpp: >+ (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough): >+ > 2019-01-28 Antoine Quint <graouts@apple.com> > > Limit user-agent interactions based on the touch-action property on iOS >diff --git a/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp b/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp >index e18cb292031515c4915c2dbb7401b8512416752f..cb62a120845bb7663851dc7c6ac9e9beb13fc97b 100644 >--- a/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp >+++ b/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp >@@ -395,9 +395,6 @@ bool BlockFormattingContext::MarginCollapse::marginsCollapseThrough(const Layout > if (!downcast<Container>(layoutBox).hasInFlowChild()) > return !establishesBlockFormattingContext(layoutBox); > >- if (Quirks::needsStretching(layoutState, layoutBox)) >- return false; >- > if (layoutBox.establishesFormattingContext()) { > if (layoutBox.establishesInlineFormattingContext()) { > // If we get here through margin estimation, we don't necessarily have an actual state for this layout box since
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193948
: 360433