Attachment 360376 Details for Bug 193456 – [PATCH] For Landing

[patch] [PATCH] For Landing

for-landing-sb-1.patch (text/plain), 1.47 KB, created by Joseph Pecoraro on 2019-01-28 14:38:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-28 14:38:54 PST

Size: 1.47 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5d0f5d9cf49..2e112616713 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-28  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        [iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash
>+        https://bugs.webkit.org/show_bug.cgi?id=193456
>+        <rdar://problem/47275642>
>+
>+        Reviewed by Brent Fulgham.
>+
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
>+        Allow access to iconservices.
>+
> 2019-01-28  Chris Dumez  <cdumez@apple.com>
> 
>         Regression(PSON) Crash under WebPageProxy::didStartProgress()
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index 209f46ce0a1..a60b87f272b 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -170,7 +170,8 @@
>     (well-known-system-group-container-subpath "/systemgroup.com.apple.lsd.iconscache"))
> (allow mach-lookup
>     (xpc-service-name "com.apple.lsdiconservice") ;; Remove this line after <rdar://problem/47151295> is fixed.
>-    (xpc-service-name "com.apple.iconservice"))
>+    (xpc-service-name "com.apple.iconservices")
>+    (global-name "com.apple.iconservices"))
> 
> ;; Common mach services needed by UIKit.
> (allow mach-lookup

Actions: View | Formatted Diff | Diff

Attachments on bug 193456: 359190 | 360210 | 360376