Attachment 360364 Details for Bug 193921 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

thing-1.patch (text/plain), 3.37 KB, created by Joseph Pecoraro on 2019-01-28 13:20:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-28 13:20:26 PST

Size: 3.37 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9d2e6a8e0bd..2ce273afefa 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-28  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler
>+        https://bugs.webkit.org/show_bug.cgi?id=193921
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Utilities.js:
>+        * UserInterface/Debug/UncaughtExceptionReporter.js:
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView.prototype._exportHAR):
>+        * UserInterface/Views/TextEditor.js:
>+        (WI.TextEditor.prototype.updateFormattedState):
>+
> 2019-01-25  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Improve Dark Mode appearance within Memory timeline
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Utilities.js b/Source/WebInspectorUI/UserInterface/Base/Utilities.js
>index 9bf08943dc7..9c2a670ff72 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Utilities.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Utilities.js
>@@ -1708,10 +1708,3 @@ function blobAsText(blob, callback)
>     fileReader.addEventListener("loadend", () => { callback(fileReader.result); });
>     fileReader.readAsText(blob);
> }
>-
>-if (!window.handlePromiseException) {
>-    window.handlePromiseException = function handlePromiseException(error)
>-    {
>-        console.error("Uncaught exception in Promise", error);
>-    };
>-}
>diff --git a/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js b/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js
>index 3f8c8688ca2..e6a5eb33349 100644
>--- a/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js
>+++ b/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js
>@@ -288,6 +288,6 @@ Document any additional information that might be useful in resolving the proble
> }
> 
> window.addEventListener("error", handleUncaughtException);
>-window.handlePromiseException = window.handleInternalException = handleError;
>+window.handleInternalException = handleError;
> 
> })();
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index aa6f45e39e7..f4e76ca5e94 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -1923,7 +1923,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
>                 content: JSON.stringify(har, null, 2),
>                 forceSaveAs: true,
>             });
>-        }).catch(handlePromiseException);
>+        });
>     }
> 
>     _waterfallPopoverContent()
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TextEditor.js b/Source/WebInspectorUI/UserInterface/Views/TextEditor.js
>index 8ee382a077b..ab96d39f375 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TextEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TextEditor.js
>@@ -200,7 +200,7 @@ WI.TextEditor = class TextEditor extends WI.View
> 
>     updateFormattedState(formatted)
>     {
>-        return this._format(formatted).catch(handlePromiseException);
>+        return this._format(formatted);
>     }
> 
>     hasFormatter()

Flags:

hi: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193921: 360364 | 360366