WebKit Bugzilla
Attachment 360339 Details for
Bug 193906
: WebDriver: POST commands require a valid parameters object
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
wd-post-empty-body.diff (text/plain), 1.60 KB, created by
Carlos Garcia Campos
on 2019-01-28 06:48:59 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Carlos Garcia Campos
Created:
2019-01-28 06:48:59 PST
Size:
1.60 KB
patch
obsolete
>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog >index 392158000d6..ecfbe57ede2 100644 >--- a/Source/WebDriver/ChangeLog >+++ b/Source/WebDriver/ChangeLog >@@ -1,3 +1,18 @@ >+2019-01-28 Carlos Garcia Campos <cgarcia@igalia.com> >+ >+ WebDriver: POST commands require a valid parameters object >+ https://bugs.webkit.org/show_bug.cgi?id=193906 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ We are not failing when http body is empty. >+ >+ Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value >+ imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value >+ >+ * WebDriverService.cpp: >+ (WebDriver::WebDriverService::handleRequest): >+ > 2019-01-04 Carlos Garcia Campos <cgarcia@igalia.com> > > WebDriver: element click command should handle user prompts >diff --git a/Source/WebDriver/WebDriverService.cpp b/Source/WebDriver/WebDriverService.cpp >index e526882c3ae..05bc953f7f0 100644 >--- a/Source/WebDriver/WebDriverService.cpp >+++ b/Source/WebDriver/WebDriverService.cpp >@@ -236,7 +236,7 @@ void WebDriverService::handleRequest(HTTPRequestHandler::Request&& request, Func > } > > RefPtr<JSON::Object> parametersObject; >- if (method.value() == HTTPMethod::Post && request.dataLength) { >+ if (method.value() == HTTPMethod::Post) { > RefPtr<JSON::Value> messageValue; > if (!JSON::Value::parseJSON(String::fromUTF8(request.data, request.dataLength), messageValue)) { > sendResponse(WTFMove(replyHandler), CommandResult::fail(CommandResult::ErrorCode::InvalidArgument));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mcatanzaro
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193906
: 360339