Attachment 360332 Details for Bug 193883 – Proposed patch

[patch] Proposed patch

0001-ews-app-Rename-id-variables.patch (text/plain), 8.66 KB, created by Aakash Jain on 2019-01-28 04:45:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-28 04:45:19 PST

Size: 8.66 KB

patch

obsolete

>From 57d2feac1765b5f42067cc7926e0552c613061ad Mon Sep 17 00:00:00 2001
>From: Aakash Jain <aakash_jain@apple.com>
>Date: Sun, 27 Jan 2019 14:19:10 -0500
>Subject: [PATCH 1/4] [ews-app] Rename id variables
> https://bugs.webkit.org/show_bug.cgi?id=193883
>
>Reviewed by NOBODY (OOPS!).
>
>* BuildSlaveSupport/ews-app/ews/models/build.py:
>* BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
>* BuildSlaveSupport/ews-app/ews/models/step.py:
>* BuildSlaveSupport/ews-app/ews/urls.py:
>* BuildSlaveSupport/ews-app/ews/views/patch.py:
>* BuildSlaveSupport/ews-app/ews/views/results.py:
>* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>---
> .../BuildSlaveSupport/ews-app/ews/models/build.py |  8 ++++----
> .../ews-app/ews/models/buildermapping.py          |  4 ++--
> .../BuildSlaveSupport/ews-app/ews/models/step.py  |  4 ++--
> Tools/BuildSlaveSupport/ews-app/ews/urls.py       |  8 ++++----
> .../BuildSlaveSupport/ews-app/ews/views/patch.py  | 10 +++++-----
> .../ews-app/ews/views/results.py                  |  6 +++---
> .../ews-app/ews/views/statusbubble.py             |  6 +++---
> Tools/ChangeLog                                   | 15 +++++++++++++++
> 8 files changed, 38 insertions(+), 23 deletions(-)
>
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/build.py b/Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>index 46b4b278c30..913a239cb5f 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -28,8 +28,8 @@ from ews.models.patch import Patch
> 
> class Build(models.Model):
>     patch = models.ForeignKey(Patch, on_delete=models.CASCADE)
>-    buildid = models.IntegerField(primary_key=True)
>-    builderid = models.IntegerField()
>+    build_id = models.IntegerField(primary_key=True)
>+    builder_id = models.IntegerField()
>     number = models.IntegerField()
>     result = models.IntegerField()
>     state_string = models.TextField()
>@@ -39,4 +39,4 @@ class Build(models.Model):
>     modified = models.DateTimeField(auto_now=True)
> 
>     def __str__(self):
>-        return str(self.buildid)
>+        return str(self.build_id)
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py b/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>index dbc82787ae7..fccba5f1112 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>@@ -26,8 +26,8 @@ from django.db import models
> 
> 
> class BuilderMapping(models.Model):
>-    builderid = models.IntegerField(primary_key=True)
>+    builder_id = models.IntegerField(primary_key=True)
>     name = models.TextField()
> 
>     def __str__(self):
>-        return "{}: {}".format(self.builderid, self.name)
>+        return "{}: {}".format(self.builder_id, self.name)
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/step.py b/Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>index 634f370539e..d8ff727ee66 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>@@ -27,7 +27,7 @@ from ews.models.build import Build
> 
> 
> class Step(models.Model):
>-    stepid = models.IntegerField(primary_key=True)
>+    step_id = models.IntegerField(primary_key=True)
>     build = models.ForeignKey(Build, on_delete=models.CASCADE)
>     result = models.IntegerField()
>     state_string = models.TextField()
>@@ -37,4 +37,4 @@ class Step(models.Model):
>     modified = models.DateTimeField(auto_now=True)
> 
>     def __str__(self):
>-        return str(self.stepid)
>+        return str(self.step_id)
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/urls.py b/Tools/BuildSlaveSupport/ews-app/ews/urls.py
>index ed4ec8804bf..6773d903b5c 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/urls.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/urls.py
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -32,9 +32,9 @@ urlpatterns = [
>     # ex: /
>     url(r'^$', Index.as_view(), name='index'),
>     # ex: /patch/5
>-    url(r'^patch/(?P<patchid>[0-9]+)/$', Patch.as_view(), name='patch'),
>+    url(r'^patch/(?P<patch_id>[0-9]+)/$', Patch.as_view(), name='patch'),
>     # ex: /patch/5/results
>-    url(r'^patch/(?P<patchid>[0-9]+)/results$', Results.as_view(), name='results'),
>+    url(r'^patch/(?P<patch_id>[0-9]+)/results$', Results.as_view(), name='results'),
>     # ex: /status-bubble/5
>-    url(r'^status-bubble/(?P<patchid>[0-9]+)/$', StatusBubble.as_view(), name='statusbubble'),
>+    url(r'^status-bubble/(?P<patch_id>[0-9]+)/$', StatusBubble.as_view(), name='statusbubble'),
> ]
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py b/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py
>index 0d92ff13088..88cc20b3dc3 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -28,8 +28,8 @@ from django.views import View
> 
> 
> class Patch(View):
>-    def get(self, request, patchid):
>-        return HttpResponse("Placeholder for patch {}.".format(patchid))
>+    def get(self, request, patch_id):
>+        return HttpResponse("Placeholder for patch {}.".format(patch_id))
> 
>-    def post(self, request, patchid):
>-        return HttpResponse("Placeholder to handle post request for patch {}.".format(patchid))
>+    def post(self, request, patch_id):
>+        return HttpResponse("Placeholder to handle post request for patch {}.".format(patch_id))
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/views/results.py b/Tools/BuildSlaveSupport/ews-app/ews/views/results.py
>index 90e9521e3f5..e3f7c5ee6ac 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/views/results.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/views/results.py
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -28,5 +28,5 @@ from django.views import View
> 
> 
> class Results(View):
>-    def post(self, request, patchid):
>-        return HttpResponse("Placeholder to handle post request for result for patch: {}.".format(patchid))
>+    def post(self, request, patch_id):
>+        return HttpResponse("Placeholder to handle post request for result for patch: {}.".format(patch_id))
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py b/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>index 8acc70d3c5d..ac7e139aee1 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -28,5 +28,5 @@ from django.views import View
> 
> 
> class StatusBubble(View):
>-    def get(self, request, patchid):
>-        return HttpResponse("Placeholder for status bubble for {}.".format(patchid))
>+    def get(self, request, patch_id):
>+        return HttpResponse("Placeholder for status bubble for {}.".format(patch_id))
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d0b9672233c..a4d7c6d2e98 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-27  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Rename id variables
>+        https://bugs.webkit.org/show_bug.cgi?id=193883
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/models/build.py:
>+        * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
>+        * BuildSlaveSupport/ews-app/ews/models/step.py:
>+        * BuildSlaveSupport/ews-app/ews/urls.py:
>+        * BuildSlaveSupport/ews-app/ews/views/patch.py:
>+        * BuildSlaveSupport/ews-app/ews/views/results.py:
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+
> 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
> 
>         AX: Introduce a static accessibility tree
>-- 
>2.17.2 (Apple Git-113)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193883: 360316 | 360332