WebKit Bugzilla
Attachment 360320 Details for
Bug 189094
: ASSERTION FAILED: cache under WebCore::AXObjectCache::postTextStateChangePlatformNotification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
patch (text/plain), 4.63 KB, created by
chris fleizach
on 2019-01-27 22:48:07 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
chris fleizach
Created:
2019-01-27 22:48:07 PST
Size:
4.63 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 240558) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,21 @@ >+2019-01-27 Chris Fleizach <cfleizach@apple.com> >+ >+ ASSERTION FAILED: cache under WebCore::AXObjectCache::postTextStateChangePlatformNotification >+ https://bugs.webkit.org/show_bug.cgi?id=189094 >+ <rdar://problem/43853526> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Protect against access to objects and cache's that can be removed while an object is still in memory. >+ >+ Unskipped flaky tests on mac-wk2. >+ >+ * accessibility/mac/AXObjectCacheMac.mm: >+ (WebCore::AXObjectCache::postTextStateChangePlatformNotification): >+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: >+ (textMarkerForVisiblePosition): >+ (textMarkerRangeFromVisiblePositions): >+ > 2019-01-27 Michael Catanzaro <mcatanzaro@igalia.com> > > Unreviewed, fix WPE/GTK debug builds after r240557 >Index: Source/WebCore/accessibility/mac/AXObjectCacheMac.mm >=================================================================== >--- Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (revision 240558) >+++ Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (working copy) >@@ -408,9 +408,11 @@ > if (id wrapper = object->wrapper()) > [userInfo setObject:wrapper forKey:NSAccessibilityTextChangeElement]; > >- AXPostNotificationWithUserInfo(rootWebArea()->wrapper(), NSAccessibilitySelectedTextChangedNotification, userInfo); >- if (rootWebArea()->wrapper() != object->wrapper()) >- AXPostNotificationWithUserInfo(object->wrapper(), NSAccessibilitySelectedTextChangedNotification, userInfo); >+ if (auto root = rootWebArea()) { >+ AXPostNotificationWithUserInfo(rootWebArea()->wrapper(), NSAccessibilitySelectedTextChangedNotification, userInfo); >+ if (root->wrapper() != object->wrapper()) >+ AXPostNotificationWithUserInfo(object->wrapper(), NSAccessibilitySelectedTextChangedNotification, userInfo); >+ } > > [userInfo release]; > } >Index: Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm >=================================================================== >--- Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (revision 240558) >+++ Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (working copy) >@@ -715,7 +715,9 @@ > static id textMarkerForVisiblePosition(AXObjectCache* cache, const VisiblePosition& visiblePos) > { > ASSERT(cache); >- >+ if (!cache) >+ return nil; >+ > auto textMarkerData = cache->textMarkerDataForVisiblePosition(visiblePos); > if (!textMarkerData) > return nil; >@@ -1113,6 +1115,9 @@ > > static id textMarkerRangeFromVisiblePositions(AXObjectCache* cache, const VisiblePosition& startPosition, const VisiblePosition& endPosition) > { >+ if (!cache) >+ return nil; >+ > id startTextMarker = textMarkerForVisiblePosition(cache, startPosition); > id endTextMarker = textMarkerForVisiblePosition(cache, endPosition); > return textMarkerRangeFromMarkers(startTextMarker, endTextMarker); >Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 240558) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2019-01-27 Chris Fleizach <cfleizach@apple.com> >+ >+ ASSERTION FAILED: cache under WebCore::AXObjectCache::postTextStateChangePlatformNotification >+ https://bugs.webkit.org/show_bug.cgi?id=189094 >+ <rdar://problem/43853526> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Unskip flaky test with crash resolved. >+ >+ * platform/mac-wk2/TestExpectations: >+ > 2019-01-26 Simon Fraser <simon.fraser@apple.com> > > Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node >Index: LayoutTests/platform/mac-wk2/TestExpectations >=================================================================== >--- LayoutTests/platform/mac-wk2/TestExpectations (revision 240558) >+++ LayoutTests/platform/mac-wk2/TestExpectations (working copy) >@@ -896,8 +896,6 @@ > imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ] > imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ] > >-webkit.org/b/189094 [ HighSierra+ ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ] >- > webkit.org/b/189598 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Pass Failure ] > > # Skip local authenticator tests for mac now.
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189094
:
348423
| 360320