Attachment 360314 Details for Bug 193892 – Proposed patch

[patch] Proposed patch

ews-app-empty-fields.patch (text/plain), 2.37 KB, created by Aakash Jain on 2019-01-27 20:11:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-27 20:11:42 PST

Size: 2.37 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240558)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-01-27  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Allow certain fields to be empty
>+        https://bugs.webkit.org/show_bug.cgi?id=193892
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/models/build.py:
>+        * BuildSlaveSupport/ews-app/ews/models/step.py:
>+
> 2018-12-15  Darin Adler  <darin@apple.com>
> 
>         Replace many uses of String::format with more type-safe alternatives
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/build.py	(revision 240558)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/build.py	(working copy)
>@@ -31,10 +31,10 @@ class Build(models.Model):
>     buildid = models.IntegerField(primary_key=True)
>     builderid = models.IntegerField()
>     number = models.IntegerField()
>-    result = models.IntegerField()
>+    result = models.IntegerField(null=True, blank=True)
>     state_string = models.TextField()
>-    started_at = models.IntegerField()
>-    complete_at = models.IntegerField()
>+    started_at = models.IntegerField(null=True, blank=True)
>+    complete_at = models.IntegerField(null=True, blank=True)
>     created = models.DateTimeField(auto_now_add=True)
>     modified = models.DateTimeField(auto_now=True)
> 
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(revision 240558)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(working copy)
>@@ -29,10 +29,10 @@ from ews.models.build import Build
> class Step(models.Model):
>     stepid = models.IntegerField(primary_key=True)
>     build = models.ForeignKey(Build, on_delete=models.CASCADE)
>-    result = models.IntegerField()
>+    result = models.IntegerField(null=True, blank=True)
>     state_string = models.TextField()
>-    started_at = models.IntegerField()
>-    complete_at = models.IntegerField()
>+    started_at = models.IntegerField(null=True, blank=True)
>+    complete_at = models.IntegerField(null=True, blank=True)
>     created = models.DateTimeField(auto_now_add=True)
>     modified = models.DateTimeField(auto_now=True)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193892: 360314