Attachment 360306 Details for Bug 193887 – Proposed patch

[patch] Proposed patch

ews-build-print-configuration.patch (text/plain), 3.25 KB, created by Aakash Jain on 2019-01-27 12:41:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-27 12:41:55 PST

Size: 3.25 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240554)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-27  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add build step to print bot Configuration
>+        https://bugs.webkit.org/show_bug.cgi?id=193887
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (PrintConfiguration): Build step to print configuration.
>+        * BuildSlaveSupport/ews-build/factories.py:
>+
> 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
> 
>         AX: Introduce a static accessibility tree
>Index: Tools/BuildSlaveSupport/ews-build/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/factories.py	(revision 240554)
>+++ Tools/BuildSlaveSupport/ews-build/factories.py	(working copy)
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -36,6 +36,7 @@ class Factory(factory.BuildFactory):
>         if checkRelevance:
>             self.addStep(CheckPatchRelevance())
>         self.addStep(ValidatePatch())
>+        self.addStep(PrintConfiguration())
>         self.addStep(CheckOutSource())
>         self.addStep(ApplyPatch())
> 
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 240554)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -1,4 +1,4 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -20,6 +20,7 @@
> # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
>+from buildbot.plugins import steps, util
> from buildbot.process import buildstep, logobserver, properties
> from buildbot.process.results import Results, SUCCESS, FAILURE, WARNINGS, SKIPPED, EXCEPTION, RETRY
> from buildbot.steps import master, shell, transfer
>@@ -741,3 +742,23 @@ class ExtractTestResults(master.MasterSh
>     def finished(self, result):
>         self.addCustomURLs()
>         return master.MasterShellCommand.finished(self, result)
>+
>+
>+class PrintConfiguration(steps.ShellSequence):
>+    name = 'configuration'
>+    description = ['configuration']
>+    descriptionDone = ['configuration']
>+    haltOnFailure = False
>+    flunkOnFailure = False
>+    warnOnFailure = False
>+    command_list = [['hostname'],
>+                    ['df', '-hl'],
>+                    ['date'],
>+                    ['sw_vers'],
>+                    ['xcodebuild', '-sdk', '-version']]
>+
>+    def __init__(self, **kwargs):
>+        super(PrintConfiguration, self).__init__(timeout=60, **kwargs)
>+        self.commands = []
>+        for command in self.command_list:
>+            self.commands.append(util.ShellArg(command=command, logfile=command[0]))

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193887: 360306