Attachment 360210 Details for Bug 193456 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

better-1.patch (text/plain), 1.36 KB, created by Joseph Pecoraro on 2019-01-25 19:04:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-25 19:04:34 PST

Size: 1.36 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3f711eaa3f8..e74a2f1a0ad 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-25  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        [iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash
>+        https://bugs.webkit.org/show_bug.cgi?id=193456
>+        <rdar://problem/47275642>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
>+        Allow access to iconservices.
>+
> 2019-01-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         iOS: Split keyboard should not shrink visualViewport.height
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index eb9f04631b3..e255b1a6e11 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -171,6 +171,8 @@
> (allow mach-lookup
>     (xpc-service-name "com.apple.lsdiconservice") ;; Remove this line after <rdar://problem/47151295> is fixed.
>     (xpc-service-name "com.apple.iconservice"))
>+(allow mach-lookup
>+    (global-name "com.apple.iconservices"))
> 
> ;; Common mach services needed by UIKit.
> (allow mach-lookup

Flags:

bfulgham: review+
bfulgham: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 193456: 359190 | 360210 | 360376