WebKit Bugzilla
Attachment 360203 Details for
Bug 193861
: Web Inspector: Audit: unable to import audits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
193861.diff (text/plain), 1.66 KB, created by
Devin Rousso
on 2019-01-25 18:25:56 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-01-25 18:25:56 PST
Size:
1.66 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 559aaf63541..472da927915 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,11 @@ >+2019-01-25 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Audit: unable to import audits >+ https://bugs.webkit.org/show_bug.cgi?id=193861 >+ >+ * UserInterface/Controllers/AuditManager.js: >+ (WI.AuditManager.prototype.async processJSON): >+ > 2019-01-25 Devin Rousso <drousso@apple.com> > > Web Inspector: Timelines: DOMContentLoaded and load event lines need to be more obvious >diff --git a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js >index 45a789d4be4..815212d83dd 100644 >--- a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js >+++ b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js >@@ -198,8 +198,8 @@ WI.AuditManager = class AuditManager extends WI.Object > return; > } > >- if (json.type !== WI.AuditTestCase.TypeIdentifier || json.type !== WI.AuditTestGroup.TypeIdentifier >- || json.type !== WI.AuditTestCaseResult.TypeIdentifier || json.type !== WI.AuditTestGroupResult.TypeIdentifier) { >+ if (json.type !== WI.AuditTestCase.TypeIdentifier && json.type !== WI.AuditTestGroup.TypeIdentifier >+ && json.type !== WI.AuditTestCaseResult.TypeIdentifier && json.type !== WI.AuditTestGroupResult.TypeIdentifier) { > WI.AuditManager.synthesizeError(WI.UIString("unknown %s \u0022%s\u0022").format(WI.unlocalizedString("type"), json.type)); > return; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
joepeck
:
review+
commit-queue
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193861
:
360203
|
360209