WebKit Bugzilla
Attachment 360182 Details for
Bug 193853
: Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193853-20190125155851.patch (text/plain), 1.87 KB, created by
Tim Horton
on 2019-01-25 15:58:51 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tim Horton
Created:
2019-01-25 15:58:51 PST
Size:
1.87 KB
patch
obsolete
>Subversion Revision: 240498 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 63628a1607b286c2b476611a148d305f0172d4a6..4ce457e19ad14bcf6db6fe1216bff6051ea3b249 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2019-01-25 Tim Horton <timothy_horton@apple.com> >+ >+ Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible >+ https://bugs.webkit.org/show_bug.cgi?id=193853 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebProcess/WebPage/ios/FindControllerIOS.mm: >+ (WebKit::FindController::updateFindIndicator): >+ There is no reason to scroll/zoom to the find indicator just because the >+ holes are up, we should only do it on initial indicator presentation. >+ This was a mistake in r178755 that was previously never exercised because >+ isShowingOverlay was always false. >+ > 2019-01-25 Brent Fulgham <bfulgham@apple.com> > > Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess. >diff --git a/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm >index fba5b056a4c9fad0171c1883f00cebf5a357f561..3c1b0eac5ef18c22871b78cd9d4352bfe556226d 100644 >--- a/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm >+++ b/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm >@@ -105,7 +105,7 @@ bool FindController::updateFindIndicator(Frame& selectedFrame, bool isShowingOve > m_findIndicatorOverlay->setFrame(enclosingIntRect(textIndicator->textBoundingRectInRootViewCoordinates())); > m_findIndicatorOverlay->setNeedsDisplay(); > >- if (isShowingOverlay || shouldAnimate) { >+ if (shouldAnimate) { > FloatRect visibleContentRect = m_webPage->mainFrameView()->unobscuredContentRectIncludingScrollbars(); > > bool isReplaced;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193853
: 360182