WebKit Bugzilla
Attachment 360178 Details for
Bug 193844
: Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193844-20190125154026.patch (text/plain), 4.87 KB, created by
Alex Christensen
on 2019-01-25 15:40:27 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2019-01-25 15:40:27 PST
Size:
4.87 KB
patch
obsolete
>Index: Source/WebCore/PAL/ChangeLog >=================================================================== >--- Source/WebCore/PAL/ChangeLog (revision 240518) >+++ Source/WebCore/PAL/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-01-25 Alex Christensen <achristensen@webkit.org> >+ >+ Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess >+ https://bugs.webkit.org/show_bug.cgi?id=193844 >+ >+ Reviewed by Andy Estes. >+ >+ * pal/spi/mac/HIServicesSPI.h: >+ > 2019-01-25 David Kilzer <ddkilzer@apple.com> > > Move soft-linking of Lookup.framework out of LookupSPI.h >Index: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h >=================================================================== >--- Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (revision 240513) >+++ Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (working copy) >@@ -123,5 +123,6 @@ CFTypeID AXTextMarkerRangeGetTypeID(); > CoreDragRef CoreDragGetCurrentDrag(); > OSStatus CoreDragSetImage(CoreDragRef, CGPoint imageOffset, CoreDragImageSpec*, CGSRegionObj imageShape, float overallAlpha); > const UInt8* AXTextMarkerGetBytePtr(AXTextMarkerRef); >+OSStatus SetApplicationIsDaemon(Boolean); > > WTF_EXTERN_C_END >Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 240516) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,19 @@ >+2019-01-25 Alex Christensen <achristensen@webkit.org> >+ >+ Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess >+ https://bugs.webkit.org/show_bug.cgi?id=193844 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction. >+ >+ * NetworkProcess/mac/NetworkProcessMac.mm: >+ (WebKit::NetworkProcess::initializeProcess): >+ * Shared/ios/ChildProcessIOS.mm: >+ (WebKit::ChildProcess::setApplicationIsDaemon): Deleted. >+ * Shared/mac/ChildProcessMac.mm: >+ (WebKit::ChildProcess::setApplicationIsDaemon): Deleted. >+ > 2019-01-25 Alex Christensen <achristensen@webkit.org> > > Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning >Index: Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm >=================================================================== >--- Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm (revision 240513) >+++ Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm (working copy) >@@ -42,6 +42,7 @@ > #import <notify.h> > #import <pal/spi/cf/CFNetworkSPI.h> > #import <pal/spi/cocoa/LaunchServicesSPI.h> >+#import <pal/spi/mac/HIServicesSPI.h> > #import <sysexits.h> > #import <wtf/FileSystem.h> > #import <wtf/MemoryPressureHandler.h> >@@ -52,8 +53,13 @@ using namespace WebCore; > > void NetworkProcess::initializeProcess(const ChildProcessInitializationParameters&) > { >+#if PLATFORM(MAC) && !PLATFORM(IOSMAC) > // Having a window server connection in this process would result in spin logs (<rdar://problem/13239119>). >- setApplicationIsDaemon(); >+ OSStatus error = SetApplicationIsDaemon(true); >+ ASSERT_UNUSED(error, error == noErr); >+#endif >+ >+ launchServicesCheckIn(); > } > > void NetworkProcess::initializeProcessName(const ChildProcessInitializationParameters& parameters) >Index: Source/WebKit/Shared/ios/ChildProcessIOS.mm >=================================================================== >--- Source/WebKit/Shared/ios/ChildProcessIOS.mm (revision 240513) >+++ Source/WebKit/Shared/ios/ChildProcessIOS.mm (working copy) >@@ -46,10 +46,6 @@ > > namespace WebKit { > >-void ChildProcess::setApplicationIsDaemon() >-{ >-} >- > void ChildProcess::platformInitialize() > { > FloatingPointEnvironment& floatingPointEnvironment = FloatingPointEnvironment::singleton(); >Index: Source/WebKit/Shared/mac/ChildProcessMac.mm >=================================================================== >--- Source/WebKit/Shared/mac/ChildProcessMac.mm (revision 240513) >+++ Source/WebKit/Shared/mac/ChildProcessMac.mm (working copy) >@@ -76,9 +76,6 @@ typedef bool (^LSServerConnectionAllowed > extern "C" void _LSSetApplicationLaunchServicesServerConnectionStatus(uint64_t flags, LSServerConnectionAllowedBlock block); > extern "C" CFDictionaryRef _LSApplicationCheckIn(LSSessionID sessionID, CFDictionaryRef applicationInfo); > >-extern "C" OSStatus SetApplicationIsDaemon(Boolean isDaemon); >- >- > namespace WebKit { > using namespace WebCore; > >@@ -152,17 +149,6 @@ static void initializeTimerCoalescingPol > ASSERT_UNUSED(kr, kr == KERN_SUCCESS); > } > >-void ChildProcess::setApplicationIsDaemon() >-{ >-#if !PLATFORM(IOSMAC) >- OSStatus error = SetApplicationIsDaemon(true); >- ASSERT_UNUSED(error, error == noErr); >-#endif >- >- // FIXME: Is this needed in iOSMac? >- launchServicesCheckIn(); >-} >- > void ChildProcess::launchServicesCheckIn() > { > _LSSetApplicationLaunchServicesServerConnectionStatus(0, 0);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193844
:
360155
| 360178