Attachment 360153 Details for Bug 167341 – Patch

[patch] Patch

bug-167341-20190125132813.patch (text/plain), 35.42 KB, created by Chris Dumez on 2019-01-25 13:28:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-01-25 13:28:14 PST

Size: 35.42 KB

patch

obsolete

>Subversion Revision: 240475
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index dfbc786068d3962e25f0c2697a1d07dde458a25c..0f2c26cb27e9fbcdcb9946a04e515b2109ab2c8e 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-25  Chris Dumez  <cdumez@apple.com>
>+
>+        [iOS] Add support for the download attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=167341
>+        <rdar://problem/30296281>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Turn on HTML download attribute support on iOS.
>+
>+        * wtf/FeatureDefines.h:
>+
> 2019-01-24  Youenn Fablet  <youenn@apple.com>
> 
>         Use MonotonicTime in WorkerRunLoop
>diff --git a/Source/WTF/wtf/FeatureDefines.h b/Source/WTF/wtf/FeatureDefines.h
>index 52721af76a2707e09dca57d0b618c51a9051a4eb..7f177559519b215633658832992aed32b2668a22 100644
>--- a/Source/WTF/wtf/FeatureDefines.h
>+++ b/Source/WTF/wtf/FeatureDefines.h
>@@ -162,7 +162,7 @@ the public iOS SDK. See <https://webkit.org/b/179167>. */
> #endif
> 
> #if !defined(ENABLE_DOWNLOAD_ATTRIBUTE)
>-#define ENABLE_DOWNLOAD_ATTRIBUTE 0
>+#define ENABLE_DOWNLOAD_ATTRIBUTE 1
> #endif
> 
> #if !defined(ENABLE_WKLEGACYPDFVIEW)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 16337f390ccf874626a8b5daad1d6712f8f60815..ad06847bf0f952f70a5f4dfc057e93532b3c3ad4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,42 @@
>+2019-01-25  Chris Dumez  <cdumez@apple.com>
>+
>+        [iOS] Add support for the download attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=167341
>+        <rdar://problem/30296281>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make download attribute layout tests iOS-friendly and unskip them now that they pass.
>+
>+        * fast/dom/HTMLAnchorElement/anchor-download-unset.html:
>+        * fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
>+        * fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
>+        * fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
>+        * fast/dom/HTMLAnchorElement/anchor-nodownload.html:
>+        * http/tests/download/anchor-download-attribute-content-disposition.html:
>+        * http/tests/download/anchor-download-no-extension.html:
>+        * http/tests/download/anchor-download-no-value.html:
>+        * http/tests/download/anchor-download-redirect.html:
>+        * http/tests/download/area-download.html:
>+        * http/tests/download/convert-cached-load-to-download.html:
>+        * http/tests/security/anchor-download-allow-blob.html:
>+        * http/tests/security/anchor-download-allow-data.html:
>+        * http/tests/security/anchor-download-allow-sameorigin.html:
>+        * http/tests/security/anchor-download-block-crossorigin-expected.txt:
>+        * http/tests/security/anchor-download-block-crossorigin.html:
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt: Copied from LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt.
>+
> 2019-01-25  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: improve invalid Audit/Recording JSON error messages
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-unset.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-unset.html
>index 94c36ec3bd055e017baf414a07fa51316fa41e10..3299050adea3b9b3ac7afde77686ca4bd70f6099 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-unset.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-unset.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script type='text/javascript'>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -17,9 +19,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html
>index 67c7ce9c26f6b4da0bd14550732293f27dba5eaf..2d8fb0f7539fd42abea522dc53e5ae06e7cf2b13 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -21,9 +23,7 @@ function userClick(element)
>         alert('Click the button to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(element.offsetLeft + 5, element.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(element.offsetLeft + 5, element.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html
>index a2fb5562be27be4a7243cb06f2927011ba038b15..1f8a1dc8808eb34ba677d1564f91bc03b6d10030 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -22,9 +24,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html
>index ad0030dceab2668e175d767975b4e0bb6a627fbd..dc065d28eed6ebd5ab0276e379a63392503e8dde 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html
>index 98c0248081b5daaa304bc93b92dd5d263a85896d..252a7fddfd21f9a18376688733ba6aa40e55cfed 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html
>@@ -1,7 +1,9 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
> <base target="_blank">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html
>index 0aebd0fa0e3634f321a33261fde7c7151290dcc4..1bb1cd0dcb05e1fe79ba171581c2f190bd65b46f 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html
>index 6d17de6faacbfa2eac90b0bbb3ac9dbf67089755..13f935976fbab7f7a83fc422f4bf092930a6e5a6 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html
>index 34df83545f6a16636b99e4300b9c96e261e160b5..e99ef35770d92388800bd7a2685d2c10695bcb0c 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html
>index 9a148b6e20280dd25cac23a5960c48ba0d14c640..7d81cbc139fc10b703e1e423db0b21064a9ea023 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html
>index bdbbb79daad0e838c494401e5c0bb9fa72477262..af7741870eabf8201e92d350534382450303d2b6 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html
>index f1d34289e2be557262225e9dfdc9cc42b2b80722..35e85786ec213172ffbd26430353a6d2d8428fc1 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html
>@@ -1,7 +1,9 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
> <meta charset="utf-8">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
>index fe43d4509bc72fb962da3b203d16c69936d4b2ec..400a22eddfccb2d22417322c6748b4a7f668ee12 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download.html
>index 5f298dca2e22090adfcacf670949a8cafea4f2a4..312af4a7734cf90b9de3d1c6ae80c8de9a970983 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
>index d9a377ff85304fc82216ed892c6c900ba3e3266d..a22f61ccef2ed82e872a12b2807603c9c8fc6dac 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -18,9 +20,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload.html b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload.html
>index de2e98d2f40a5660408438456d3470d84fe8f516..42fbefde60d958a053912833433236ad55702b07 100644
>--- a/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload.html
>+++ b/LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="../../../resources/ui-helper.js"></script>
> <script type='text/javascript'>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -17,9 +19,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/http/tests/download/anchor-download-attribute-content-disposition.html b/LayoutTests/http/tests/download/anchor-download-attribute-content-disposition.html
>index 40c722f31f8104530a20e701c4eca302f1cec1f6..9908e71a2190b48204e5e405d28da14ef43e7e90 100644
>--- a/LayoutTests/http/tests/download/anchor-download-attribute-content-disposition.html
>+++ b/LayoutTests/http/tests/download/anchor-download-attribute-content-disposition.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/http/tests/download/anchor-download-no-extension.html b/LayoutTests/http/tests/download/anchor-download-no-extension.html
>index 8ec78049048e8ec991ac72d1ec3db42ee70868cd..4f148e95f6f75e79595dc3d89508ff6189d9f30b 100644
>--- a/LayoutTests/http/tests/download/anchor-download-no-extension.html
>+++ b/LayoutTests/http/tests/download/anchor-download-no-extension.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/http/tests/download/anchor-download-no-value.html b/LayoutTests/http/tests/download/anchor-download-no-value.html
>index 67c02045a77586585b78aebc8dd0a12a619dda7a..de0583c179b60a0ec2d4621339809e5c6ecf071a 100644
>--- a/LayoutTests/http/tests/download/anchor-download-no-value.html
>+++ b/LayoutTests/http/tests/download/anchor-download-no-value.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -19,9 +21,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function runTest()
>diff --git a/LayoutTests/http/tests/download/anchor-download-redirect.html b/LayoutTests/http/tests/download/anchor-download-redirect.html
>index 32d3d21ac8aaffaecf49fa7679cb3c0bcc708f55..4e677108d0eec439949b50aa30efd22b42bc01cc 100644
>--- a/LayoutTests/http/tests/download/anchor-download-redirect.html
>+++ b/LayoutTests/http/tests/download/anchor-download-redirect.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner) {
>         testRunner.dumpAsText();
>@@ -21,9 +23,7 @@ The suggested filename at the top should be foo.pdf and you should see a redirec
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/http/tests/download/area-download.html b/LayoutTests/http/tests/download/area-download.html
>index 558820426f185e0f406f5278842ecdd07919801b..9483601e704ff24c5a43281d6ea1cbfb3d3cb83c 100644
>--- a/LayoutTests/http/tests/download/area-download.html
>+++ b/LayoutTests/http/tests/download/area-download.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner) {
>         testRunner.dumpAsText();
>@@ -22,9 +24,7 @@
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 10, elmt.offsetTop + 10);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 10, elmt.offsetTop + 10);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/http/tests/download/convert-cached-load-to-download.html b/LayoutTests/http/tests/download/convert-cached-load-to-download.html
>index bf9deaceb98567379f7ada07ccced1d6f4ce64da..1a143947b422387ffb7cb3d5041d6b26f9969a49 100644
>--- a/LayoutTests/http/tests/download/convert-cached-load-to-download.html
>+++ b/LayoutTests/http/tests/download/convert-cached-load-to-download.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
> if (window.testRunner) {
>   testRunner.dumpAsText();
>@@ -22,9 +24,7 @@ function click(elmt)
>         alert('Click the link to run the test.');
>         return;
>     }
>-    eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-    eventSender.mouseDown();
>-    eventSender.mouseUp();
>+    UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
> }
> 
> function cacheTestResource(then)
>diff --git a/LayoutTests/http/tests/security/anchor-download-allow-blob.html b/LayoutTests/http/tests/security/anchor-download-allow-blob.html
>index ee42aa90bddc6ac862c5b00826c69f37e84c0005..365c79b751c2756ed82b8618ee66a2297fae8544 100644
>--- a/LayoutTests/http/tests/security/anchor-download-allow-blob.html
>+++ b/LayoutTests/http/tests/security/anchor-download-allow-blob.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner) {
>         testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ Tests that a suggested filename on a download attribute is allowed if
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/http/tests/security/anchor-download-allow-data.html b/LayoutTests/http/tests/security/anchor-download-allow-data.html
>index cacfcef06146c1ddd1a2f750ea6ef29deed9fa19..591e0a8079e1a84abc1d1cf2c6ef915a234afc18 100644
>--- a/LayoutTests/http/tests/security/anchor-download-allow-data.html
>+++ b/LayoutTests/http/tests/security/anchor-download-allow-data.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner) {
>         testRunner.dumpAsText();
>@@ -20,9 +22,7 @@ Tests that a suggested filename on a download attribute is allowed if
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/http/tests/security/anchor-download-allow-sameorigin.html b/LayoutTests/http/tests/security/anchor-download-allow-sameorigin.html
>index 5310879d1a301c778c2307a2f712ab4e406ca802..b309225183e0d2167b52eb4d9513707f34260f72 100644
>--- a/LayoutTests/http/tests/security/anchor-download-allow-sameorigin.html
>+++ b/LayoutTests/http/tests/security/anchor-download-allow-sameorigin.html
>@@ -1,6 +1,8 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner) {
>         testRunner.dumpAsText();
>@@ -21,9 +23,7 @@ The suggested filename at the top should be foo.pdf.
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt b/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt
>index f03a4bc3b25b0fa7e4b72dd3b644f9e8f3e96d75..06d6cf579627cdf0f85b663cdf238fd49c77435d 100644
>--- a/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt
>+++ b/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt
>@@ -1,4 +1,4 @@
>-CONSOLE MESSAGE: line 25: The download attribute on anchor was ignored because its href URL has a different security origin.
>+CONSOLE MESSAGE: line 88: The download attribute on anchor was ignored because its href URL has a different security origin.
> Tests that the download attribute is ignored if the link is cross origin.
> 
> It should navigate the subframe instead of downloading the file.
>diff --git a/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html b/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html
>index ed416ddbb84a599b2614023f8513a586a48d8a8c..d07247acecba1d48186e237d9c316096361d36f2 100644
>--- a/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html
>+++ b/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html
>@@ -1,7 +1,9 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html>
> <html>
> <head>
>+<meta name="viewport" content="width=device-width">
> <script src="../../../resources/js-test-pre.js"></script>
>+<script src="/js-test-resources/ui-helper.js"></script>
> <script>
>     if (window.testRunner)
>         testRunner.waitUntilDone();
>@@ -20,9 +22,7 @@ Tests that the download attribute is ignored if
>         if (!window.eventSender)
>             return;
> 
>-        eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>-        eventSender.mouseDown();
>-        eventSender.mouseUp();
>+        UIHelper.activateAt(elmt.offsetLeft + 5, elmt.offsetTop + 5);
>     }
> 
>     function runTest()
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index d51e525cdfbec667e0de2e1b47b5f47d02166ef7..2750d51d373309904ce3f1adb06f7e5d231763a6 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -1067,38 +1067,6 @@ webkit.org/b/155948 legacy-animation-engine/transitions/cancel-transition.html [
> webkit.org/b/189686 webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Skip ]
> webkit.org/b/189686 webgl/2.0.0/conformance/textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Skip ]
> 
>-
>-# <a download> does not work on iOS.
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-nodownload.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html [ Skip ]
>-webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/anchor-download-attribute-content-disposition.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/anchor-download-no-extension.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/anchor-download-redirect.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/anchor-load-after-download.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/area-download.html [ Skip ]
>-webkit.org/b/156067 http/tests/security/anchor-download-allow-blob.html [ Skip ]
>-webkit.org/b/156067 http/tests/security/anchor-download-allow-data.html [ Skip ]
>-webkit.org/b/156067 http/tests/security/anchor-download-allow-sameorigin.html [ Skip ]
>-webkit.org/b/156067 http/tests/security/anchor-download-block-crossorigin.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/anchor-download-no-value.html [ Skip ]
>-webkit.org/b/156067 http/tests/download/convert-cached-load-to-download.html [ Skip ]
>-
> webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-vary.html [ Pass Timeout ]
> webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Pass Timeout ]
> 
>diff --git a/LayoutTests/platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt b/LayoutTests/platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..142cd1f04f72d69da47f045d792db4b29aa5aff3
>--- /dev/null
>+++ b/LayoutTests/platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt
>@@ -0,0 +1,6 @@
>+CONSOLE MESSAGE: The download attribute on anchor was ignored because its href URL has a different security origin.
>+Tests that the download attribute is ignored if the link is cross origin.
>+
>+It should navigate the subframe instead of downloading the file.
>+
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 167341: 343024 | 360148 | 360153 | 360154 | 360170 | 376769