WebKit Bugzilla
Attachment 360151 Details for
Bug 193743
: Web Inspector: Audit: remove experimental setting
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193743-20190125132326.patch (text/plain), 5.98 KB, created by
Devin Rousso
on 2019-01-25 13:23:27 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-01-25 13:23:27 PST
Size:
5.98 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 868cb3d8c97fddd1e2f04f467d2247f587187bcb..9c18ce1078cde7cb95c4b62549d86880c80ff7a1 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,28 @@ >+2019-01-25 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Audit: remove experimental setting >+ https://bugs.webkit.org/show_bug.cgi?id=193743 >+ <rdar://problem/28234022> >+ >+ Reviewed by Joseph Pecoraro. >+ >+ * UserInterface/Base/Setting.js: >+ (WI.Setting): >+ (WI.Setting.localStorageKey): Added. >+ (WI.Setting.migrateValue): >+ Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`. >+ >+ * UserInterface/Base/Main.js: >+ (WI.loaded): >+ >+ * UserInterface/Views/AuditTabContentView.js: >+ (WI.AuditTabContentView.isTabAllowed): >+ >+ * UserInterface/Views/SettingsTabContentView.js: >+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView): >+ >+ * Localizations/en.lproj/localizedStrings.js: >+ > 2019-01-25 Devin Rousso <drousso@apple.com> > > Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work >diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js >index 14150cd31fe935a3f36afd77159c91919e5daa29..b4962b853499680b154f7fb8e31444e3e38fdc08 100644 >--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js >+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js >@@ -133,7 +133,6 @@ localizedStrings["Attributes"] = "Attributes"; > localizedStrings["Audit"] = "Audit"; > localizedStrings["Audit Error: %s"] = "Audit Error: %s"; > localizedStrings["Audit Warning: %s"] = "Audit Warning: %s"; >-localizedStrings["Audit:"] = "Audit:"; > localizedStrings["Audits"] = "Audits"; > localizedStrings["Author Stylesheet"] = "Author Stylesheet"; > localizedStrings["Auto Increment"] = "Auto Increment"; >@@ -361,7 +360,6 @@ localizedStrings["Element is the root element"] = "Element is the root element"; > localizedStrings["Element may overlap another compositing element"] = "Element may overlap another compositing element"; > localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element"; > localizedStrings["Elements"] = "Elements"; >-localizedStrings["Enable Audit Tab"] = "Enable Audit Tab"; > localizedStrings["Enable Breakpoint"] = "Enable Breakpoint"; > localizedStrings["Enable Breakpoints"] = "Enable Breakpoints"; > localizedStrings["Enable Computed Style Cascades"] = "Enable Computed Style Cascades"; >diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js >index 71cb8ed6bf128d1194c088f91590c5d210634933..e8cad5210a34355be812c2826f8f8df98cce975e 100644 >--- a/Source/WebInspectorUI/UserInterface/Base/Main.js >+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js >@@ -148,6 +148,7 @@ WI.loaded = function() > WI.TimelineTabContentView.Type, > WI.StorageTabContentView.Type, > WI.CanvasTabContentView.Type, >+ WI.AuditTabContentView.Type, > WI.ConsoleTabContentView.Type, > ]); > this._selectedTabIndexSetting = new WI.Setting("selected-tab-index", 0); >diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js >index 8c4226823c14a46788775b85ec6ccdbf3333dac6..9a9e68e9e198522714d5ad659c16e11735efbd0b 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js >@@ -49,7 +49,7 @@ WI.AuditTabContentView = class AuditTabContentView extends WI.ContentBrowserTabC > > static isTabAllowed() > { >- return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value; >+ return WI.sharedApp.debuggableType === WI.DebuggableType.Web; > } > > // Public >diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js >index d123dc00b75c6e96dfe4415e7274274aeb1a82e1..f5f815b2a4181ea0cc0b3cac52bf9b355d2f0508 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js >@@ -264,9 +264,6 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi > experimentalSettingsView.addSeparator(); > } > >- experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab")); >- experimentalSettingsView.addSeparator(); >- > experimentalSettingsView.addSetting(WI.UIString("User Interface:"), WI.settings.experimentalEnableNewTabBar, WI.UIString("Enable New Tab Bar")); > experimentalSettingsView.addSeparator(); > >@@ -277,8 +274,6 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi > let newTabs = WI._openTabsSetting.value.slice(); > if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value) > newTabs.push(WI.LayersTabContentView.Type); >- if (!initialValues.get(WI.settings.experimentalEnableAuditTab) && WI.settings.experimentalEnableAuditTab.value) >- newTabs.push(WI.AuditTabContentView.Type); > WI._openTabsSetting.value = newTabs; > > InspectorFrontendHost.reopen(); >@@ -296,7 +291,6 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi > > listenForChange(WI.settings.experimentalEnableComputedStyleCascades); > listenForChange(WI.settings.experimentalEnableLayersTab); >- listenForChange(WI.settings.experimentalEnableAuditTab); > listenForChange(WI.settings.experimentalEnableNewTabBar); > > this.addSettingsView(experimentalSettingsView);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193743
:
359967
| 360151