Attachment 360150 Details for Bug 193838 – Patch

[patch] Patch

bug-193838-20190125131542.patch (text/plain), 5.48 KB, created by Devin Rousso on 2019-01-25 13:15:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-25 13:15:43 PST

Size: 5.48 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1aadbdeb19807321e0bd7438b5255ca64d18153e..bc217a10e1044ea75e0df6c8d2b780473d85bb92 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,24 @@
>+2019-01-25  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: selecting a path component with no siblings does nothing
>+        https://bugs.webkit.org/show_bug.cgi?id=193838
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove `allowsMultipleSelection` flag, meaning we now always allow repeat selection.
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline):
>+        (WI.TreeOutline.prototype.selectTreeElementInternal):
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.prototype.select):
>+        * UserInterface/Views/NavigationSidebarPanel.js:
>+        (WI.NavigationSidebarPanel.prototype.createContentTreeOutline):
>+        * UserInterface/Views/AuditNavigationSidebarPanel.js:
>+        (WI.AuditNavigationSidebarPanel.prototype.initialLayout):
>+        * UserInterface/Views/OpenResourceDialog.js:
>+        (WI.OpenResourceDialog):
>+
> 2019-01-25  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: improve invalid Audit/Recording JSON error messages
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>index 1c17635cf484e2b683ad4e387eaae800fb127f6c..62d6fa75b342f8364fcc02c1248bd4e4f4b06475 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js
>@@ -69,8 +69,6 @@ WI.AuditNavigationSidebarPanel = class AuditNavigationSidebarPanel extends WI.Na
>     {
>         super.initialLayout();
> 
>-        this.contentTreeOutline.allowsRepeatSelection = false;
>-
>         let controlsNavigationBar = new WI.NavigationBar;
> 
>         this._startStopButtonNavigationItem = new WI.ToggleButtonNavigationItem("audit-start-stop", WI.UIString("Start"), WI.UIString("Stop"), "Images/AuditStart.svg", "Images/AuditStop.svg", 13, 13);
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
>index c53df4ae3a637b445c7ba1c6003094f379f3204c..99b9d243499af38afde8f15c0e32299c157ab35c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
>@@ -126,7 +126,6 @@ WI.NavigationSidebarPanel = class NavigationSidebarPanel extends WI.SidebarPanel
>     createContentTreeOutline(suppressFiltering)
>     {
>         let contentTreeOutline = new WI.TreeOutline;
>-        contentTreeOutline.allowsRepeatSelection = true;
>         contentTreeOutline.element.classList.add(WI.NavigationSidebarPanel.ContentTreeOutlineElementStyleClassName);
> 
>         this._contentTreeOutlineGroup.add(contentTreeOutline);
>diff --git a/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js b/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js
>index 7e606e6723ab1c50905fb9f01fec46c583e72e0a..41836068fc159258dda1ed9be90065c6c21c0ec5 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js
>@@ -48,7 +48,6 @@ WI.OpenResourceDialog = class OpenResourceDialog extends WI.Dialog
>         this._clearIconElement.addEventListener("click", this._handleClickEvent.bind(this));
> 
>         this._treeOutline = new WI.TreeOutline;
>-        this._treeOutline.allowsRepeatSelection = true;
>         this._treeOutline.disclosureButtons = false;
>         this._treeOutline.large = true;
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index 7af88394cc1b906df54e00c09d29a12aab3b1c47..72f091eb7b070fab798d2caf8d3d6c7a369de814 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -503,9 +503,6 @@ WI.TreeElement = class TreeElement extends WI.Object
>         if (!this.treeOutline || !this.selectable)
>             return;
> 
>-        if (this.selected && !this.treeOutline.allowsRepeatSelection)
>-            return;
>-
>         if (!omitFocus)
>             this.treeOutline._childrenListNode.focus();
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index a47e60b89af6e0def5b868a6447905f5ab29ef9d..63a113437e1296255fe97489cc3f6107c1c993c1 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -41,7 +41,6 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         this._childrenListNode.removeChildren();
>         this._knownTreeElements = [];
>         this._treeElementsExpandedState = [];
>-        this.allowsRepeatSelection = false;
>         this.root = true;
>         this.hasChildren = false;
>         this.expanded = true;
>@@ -890,11 +889,6 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         this._itemWasSelectedByUser = selectedByUser;
>         this._suppressNextSelectionDidChangeEvent = suppressNotification;
> 
>-        if (this.allowsRepeatSelection && this.selectedTreeElement === treeElement) {
>-            this._dispatchSelectionDidChangeEvent();
>-            return;
>-        }
>-
>         this.selectedTreeElement = treeElement;
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193838: 360150