WebKit Bugzilla
Attachment 360121 Details for
Bug 193830
: Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
193830.diff (text/plain), 2.04 KB, created by
Devin Rousso
on 2019-01-25 10:41:32 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-01-25 10:41:32 PST
Size:
2.04 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 1aadbdeb198..9b4a53cf32d 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-24 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work >+ https://bugs.webkit.org/show_bug.cgi?id=193830 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Models/RecordingAction.js: >+ (WI.RecordingAction.prototype.process): >+ > 2019-01-25 Devin Rousso <drousso@apple.com> > > Web Inspector: improve invalid Audit/Recording JSON error messages >diff --git a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js >index c5717c73246..5d08f7052d4 100644 >--- a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js >+++ b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js >@@ -260,11 +260,11 @@ WI.RecordingAction = class RecordingAction extends WI.Object > } > > if (WI.ImageUtilities.supportsCanvasPathDebugging()) { >- let currentX = currentState.currentX; >- let invalidX = (currentX < 0 || currentX >= context.canvas.width) && (!lastState || currentX !== lastState.currentX); >+ let currentX = currentState.get("currentX"); >+ let invalidX = (currentX < 0 || currentX >= context.canvas.width) && (!lastState || currentX !== lastState.get("currentX")); > >- let currentY = currentState.currentY; >- let invalidY = (currentY < 0 || currentY >= context.canvas.height) && (!lastState || currentY !== lastState.currentY); >+ let currentY = currentState.get("currentY"); >+ let invalidY = (currentY < 0 || currentY >= context.canvas.height) && (!lastState || currentY !== lastState.get("currentY")); > > if (invalidX || invalidY) > this._warning = WI.UIString("This action moves the path outside the visible area");
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193830
: 360121