Attachment 360118 Details for Bug 180526 – Patch

[patch] Patch

bug-180526-20190125184237.patch (text/plain), 1.88 KB, created by Rob Buis on 2019-01-25 09:42:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2019-01-25 09:42:37 PST

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 240444
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 07430bdba832a1860e1ece720935bef3343d5b40..426cad440f1200fa2eb1173a8aecb741369c79a4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-25  Rob Buis  <rbuis@igalia.com>
>+
>+        Update MIME type parser
>+        https://bugs.webkit.org/show_bug.cgi?id=180526
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://mimesniff.spec.whatwg.org/#parse-a-mime-type step 9.3
>+
>+        * platform/network/ParsedContentType.cpp:
>+        (WebCore::parseToken):
>+        (WebCore::parseContentType):
>+
> 2019-01-24  John Wilander  <wilander@apple.com>
> 
>         Add Ad Click Attribution as an internal/experimental feature
>diff --git a/Source/WebCore/platform/network/ParsedContentType.cpp b/Source/WebCore/platform/network/ParsedContentType.cpp
>index e3eabd99903c69b2149f09fa03d09b4b5bcc9f2e..be4cd35eb9bd27c7c0bca2fc0ed4bfbd4ae65341 100644
>--- a/Source/WebCore/platform/network/ParsedContentType.cpp
>+++ b/Source/WebCore/platform/network/ParsedContentType.cpp
>@@ -78,7 +78,7 @@ static Optional<SubstringRange> parseToken(const String& input, unsigned& startI
>     if (tokenEnd == tokenStart)
>         return WTF::nullopt;
>     if (skipTrailingWhitespace) {
>-        while (input[tokenEnd - 1] == ' ')
>+        while (input[tokenEnd - 1] == ' ' || input[tokenEnd - 1] == '\t')
>             --tokenEnd;
>     }
>     return SubstringRange(tokenStart, tokenEnd - tokenStart);
>@@ -264,6 +264,8 @@ bool parseContentType(const String& contentType, ReceiverType& receiver, Mode mo
>             valueRange = parseToken(contentType, index, isNotSemicolon, mode, mode == Mode::MimeSniff);
> 
>         if (!valueRange) {
>+            if (mode == Mode::MimeSniff)
>+                continue;
>             LOG_ERROR("Invalid Content-Type, invalid parameter value.");
>             return false;
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 180526: 348014 | 356923 | 356928 | 357400 | 357401 | 357403 | 357443 | 357469 | 357682 | 357684 | 357687 | 357690 | 357691 | 357702 | 358515 | 358898 | 358906 | 358907 | 358917 | 359860 | 360118 | 360123 | 360129 | 360134 | 360136 | 360144 | 360303 | 360343 | 360350 | 360355 | 362245 | 362316 | 362323 | 362342 | 362348 | 362360 | 362378 | 362384 | 362387 | 362390 | 362397 | 362416 | 362418 | 362430 | 362437 | 362483 | 362486 | 362497 | 362506 | 362526 | 390349